Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiled gallery: Improve icon size and color #29942

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Tiled gallery: Improve icon size and color #29942

merged 1 commit into from
Jan 9, 2019

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Jan 7, 2019 •
edited
Loading

Fixes #29862

  • Add width/height to the Tiled Gallery icon
  • Add currentColor fill to the icon path

Testing instructions

Does the icon look good in all contexts?

  • block toolbar
  • slash inserter – type /tiled and pick the block
  • Main inserter – click add block + from various places in Gutenberg
  • When the gallery is empty, the icon in the placeholder.

Screens

Before After
screen shot 2019-01-07 at 18 52 32 screen shot 2019-01-07 at 18 50 07
screen shot 2019-01-07 at 18 52 57 screen shot 2019-01-07 at 18 50 44
screen shot 2019-01-07 at 18 52 45 screen shot 2019-01-07 at 18 50 30

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/tiled-gallery-icon-size-color

@sirreal sirreal self-assigned this Jan 7, 2019
@sirreal sirreal added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Design [Goal] Gutenberg Working towards full integration with Gutenberg [Block] Tiled Gallery labels Jan 7, 2019
@sirreal sirreal requested a review from a team January 7, 2019 17:55
@sirreal sirreal changed the title Add icon size and currentColor to tiled gallery icon Tiled gallery: Improve icon size and color Jan 7, 2019
@sirreal sirreal added this to the Jetpack: 6.9 milestone Jan 8, 2019
ockham
ockham approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 😎

@sirreal sirreal added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 8, 2019
tyxla
tyxla approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so much better in the placeholder ❤️

@sirreal sirreal merged commit 8bdd403 into master Jan 9, 2019
@sirreal sirreal deleted the update/tiled-gallery-icon-size-color branch January 9, 2019 12:02
jeherve pushed a commit that referenced this pull request Jan 9, 2019
@sirreal @jeherve
Tiled Gallery: Add icon size and currentColor icon (#29942)
713524c
This was referenced May 15, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 3, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 5, 2021
Open
@ajesse11x ajesse11x mentioned this pull request Oct 1, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Oct 2, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Oct 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@ockham ockham ockham approved these changes

Assignees

@sirreal sirreal

Labels
[Block] Tiled Gallery Design [Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Milestone
Jetpack: 6.9
Development

Successfully merging this pull request may close these issues.
4 participants
@sirreal @matticbot @ockham @tyxla