Support User: Highlight Masterbar when active #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordwest
added
[Status] In Progress
[Feature Group] Support
jordwest
changed the title
4 tasks
jordwest
force-pushed
the
add/support-user/masterbar-highlight
branch
from
105b1b3
to
4bf9a9c
Compare
jordwest
force-pushed
the
add/support-user/masterbar-highlight
branch
from
4bf9a9c
to
adea312
Compare
| @@ -9,6 +9,16 @@ import { | |||
| SUPPORT_USER_RESTORE, | |||
| } from 'state/action-types'; | |||
|
|
|||
| export function isSupportUser( state = false, action ) { | |||
There was a problem hiding this comment.
Should this be a selector instead?
|
It's in-progress, but just a drive by with a couple of notes on the current state:
|
|
I tested this a bit and it worked well in terms of highlighting the masterbar. I did see some js errors and some rendering weirdness, but we think that's unrelated to this set of changes, and we're going to track it separately. If we can get the other feedback addressed and ping for another review once fixes are in, I'd love to get this landed in short order. |
jordwest
force-pushed
the
add/support-user/masterbar-highlight
branch
from
47ee5f8
to
95cec5e
Compare
jordwest
added
[Status] Needs Review
| @@ -145,6 +152,7 @@ export default connect( | |||
| const { isLoading, section, hasSidebar, chunkName } = state.ui; | |||
| return { | |||
| isLoading, | |||
| isSupportUser: isSupportUser( state ), | |||
There was a problem hiding this comment.
This looks much better to me, thanks.
|
🚢 tested on Chrome, FF, Safari. |
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
jordwest
added a commit
that referenced
this pull request
Feb 4, 2016
…ighlight Support User: Highlight Masterbar when active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When activating support user mode, the Masterbar is highlighted to remind you that you're not in a normal mode and could make changes that you didn't mean to.
Normal
Support user active