Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force eslint dependency escope to 3.3.0 and add shrinkwrap file #2947

Merged
merged 1 commit into from
Feb 1, 2016

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Feb 1, 2016

Works around build breakage introduced in: babel/babel-eslint#243

When adding new packages, you'll need to shrinkwrap dependencies. You may find using a command line tool to do this helpful:

https://github.com/goodeggs/clingwrap

@gwwar gwwar self-assigned this Feb 1, 2016
@gwwar gwwar added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Feb 1, 2016
@blowery
Copy link
Contributor

blowery commented Feb 1, 2016

WFM. We should add a bit to the readme on how to re-shrinkwrap things as needed, but that can be another PR.

@gwwar
Copy link
Contributor Author

gwwar commented Feb 1, 2016

@blowery Yup I'll be writing a P2 and updating the readme on updating packages today.

@artpi
Copy link
Contributor

artpi commented Feb 1, 2016

🐑 🚢

@artpi
Copy link
Contributor

artpi commented Feb 1, 2016

@blowery : I was just writing that comment :) totally agree!

@gwwar : You're awesome!

gwwar added a commit that referenced this pull request Feb 1, 2016
force eslint dependency escope to 3.3.0 and add shrinkwrap file
@gwwar gwwar merged commit a096f59 into master Feb 1, 2016
@gwwar gwwar deleted the add/shrinkwrap branch February 1, 2016 19:08
@gwwar gwwar removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Ready to Merge labels Feb 1, 2016
@hzoo
Copy link

hzoo commented Feb 1, 2016

Published a fix.

npm view babel-eslint dist-tags

{ latest: '4.1.7', next: '5.0.0-beta9' }

@gwwar
Copy link
Contributor Author

gwwar commented Feb 1, 2016

Thanks for the update @hzoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants