Map Block, With Asynchronous Loader #28498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Refactor of Frontend Management's handling of block children to avoid altering the DOM. Refactor of view.js files with component and config as properties of a single object, for greater uniformity and less code in the preset view file.
…on and popover will always be shown together. The dashed icon is no longer a button for invoking the popover. Add Marker UI will be visible when map is first revealed. Icon in Block Controls shows the Add Marker UI.
…s info window immediately appearing.
…s view.js, to simplify the presets.
…ation often caused the infowindow to jump (sometimes off screen) making it difficult or impossible to continue editing.
…t which looked suspicious. San Francisco is new default center point (to help me test using client's location, since I live in NY)
…r color and map theme are now in Panels.
…arious editor chrome.
sirreal
reviewed
Nov 14, 2018
sirreal
reviewed
Nov 14, 2018
sirreal
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
This block is great and we need to get it merged. Several folks have already gone over it, but there are certainly a few things left to do.
With this PR it will be included in the Jetpack beta blocks and nowhere else, which makes this relatively safe.
Let's get together a list of the remaining bits that will be handled in smaller, more targeted follow-up PRs and 🚢 🚢 🚢
sirreal
added
Jetpack
[Status] Ready to Merge
[Goal] Gutenberg
lezama
reviewed
Nov 14, 2018
This was referenced Nov 20, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This is identical to the Map block PR except that it replaces the Calypso loadScript utility with a custom async loader utility that manages scripts and stylesheets. In the Map block, this utility is used to load the Mapbox script and stylesheet at runtime. At some point in the future, making a library like this available in Gutenberg core might be a valuable addition for plugin authors (cc: @mtias).
Also, Map block has been removed from the Jetpack preset and added to Jetpack Beta, so
JETPACK_BETA_BLOCKSconstant will need to be set to test.Testing instructions
Jurassic Ninja link: https://jurassic.ninja/create/?gutenberg&gutenpack&shortlived&jetpack-beta&calypsobranch=try/map+loader&branch=try/google-maps-api-key
Set Up JetpackStart with freeActivate recommended featuresSSH in using connection string and password found in the persistent admin notice in the site’s wp-admincd ~/apps/$USER/publicwp config set JETPACK_BETA_BLOCKS true --raw --type=constantSettings->Jetpack ConstantsJETPACK_BETA_BLOCKSand Save.Map