i18n: Extract wp/i18n translatable strings #28200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirk
added
[Status] Needs Review
tyxla
reviewed
Nov 2, 2018
package.json
Outdated
| @@ -267,7 +267,7 @@ | |||
| "test-server": "jest -c=test/server/jest.config.js", | |||
| "test-server:coverage": "npm run -s test-server -- --coverage", | |||
| "test-server:watch": "npm run -s test-server -- --watch", | |||
| "translate": "i18n-calypso --format pot --output-file ./calypso-strings.pot -e date \"**/*.js\" \"**/*.jsx\" \"!build/**\" \"!node_modules/**\" \"!public/**\"", | |||
| "translate": "i18n-calypso --format pot --output-file ./calypso-strings.pot -k translate,__,_x,_n -e date \"**/*.js\" \"**/*.jsx\" \"!build/**\" \"!node_modules/**\" \"!public/**\"", | |||
There was a problem hiding this comment.
Are we planning to also target _nx()?
akirk
force-pushed
the
add/i18n-extract-gutenberg-strings
branch
from
ea1d178 to
874b1a0
Compare
matticbot
removed
the
[Status] Needs Review
akirk
added a commit
that referenced
this pull request
Nov 27, 2018
…he CI (#28842) * Framework: Add @wordpress/babel-plugin-makepot dev dependency * Build: Use makepot Babel plugin to build pot file * Revert "i18n: Extract wp/i18n translatable strings (#28200)" This reverts commit 242414e. * Start with a babel-plugin-i18n-calypso * typo * Try to avoid need for building by using CJS * Extract translate calls to POT * Integrate babel-plugin-makepot * Remove the translate command * Try a new NODE_ENV * set the calypso env * WIP write to different files to see where strings are dropped * Write single files and concat them using msgcat * Make sure msgcat is available on CircleCI * Remove makepot functionality * Move build files into the build directory * Unify POT headers * Improve POT filenames * Incorporate review feedback * typo * Format plugin with prettier * Remove CI related changes * Build POT using the Babel plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Gutenberg-style translatable strings (
__(),_x(),_n(), and_nx()) to the methods we extract for translation.Testing instructions
Compare with the
npm run translatewithout this change to make sure this only adds and not removes strings tocalypso-strings.pot.You could use
difforpodiffto check this with a sequence of commands like this:(Unfortunately podiff has a bug regarding multiline contexts, so you'll need to use my patched version).