Gutenberg: Add i18n wrappers to provide the Jetpack textdomain

[tyxla]

It seems we'll have to ditch the textdomain from the i18n function calls in our blocks for good. Reason: it messes with how xgettext-js parses the files.

However, we need to still provide the textdomain so Gutenberg would be able to find the Jetpack translations where they are.

To address this, we provide wrappers for the wp.i18n functions that add the textdomain, and by this:

• Gutenberg will still have the textdomain at the time the i18n function is called.
• Jetpack will not have the textdomain, as it will index our wrapper functions instead, so indexing will work well.

Changes proposed in this Pull Request

• Remove jetpack textdomain from any Jetpack blocks in order to allow Jetpack to index the translations properly.
• Introduce wrappers for @wordpress/i18n l10n functions.
• Use i18n wrappers instead of @wordpress/i18n

Testing instructions

• See i18n extractor: extract strings from Gutenberg Blocks. jetpack#10391 for testing instructions.

[matticbot]

Test live: https://calypso.live/?branch=remove/gutenberg-jetpack-textdomain

[ockham]

It seems we'll have to ditch the textdomain froIt seems we'll have to ditch the textdomain from the i18n function calls in our blocks for good. Reason: it messes with how xgettext-js parses the files.

Note, we've been discussing (pa9srA-W-p2) using the @wordpress/babel-plugin-makepot (which is already used by Gutenberg) instead of xgettext-js.

/cc @akirk

[tyxla]

Note, we've been discussing (pa9srA-W-p2) using the @wordpress/babel-plugin-makepot (which is already used by Gutenberg) instead of xgettext-js.

If this can be a quick change, that sounds good, but if it takes a while, FWIW it will be a blocker for shipping localized and translatable Jetpack blocks.

[tyxla]

Well, it seems that if we remove textdomain, we'll remove the possibility for wp.i18n to find translations...

I'll try with a different solution, likely with our wrappers for the wp.i18n localization functions.

[tyxla]

I'll try with a different solution, likely with our wrappers for the wp.i18n localization functions.

Done, this is ready for another review.

[tyxla]

Placing it under [Pri] High as this needs to land soon to allow Jetpack blocks to be translatable.

[tyxla]

Also, rebased.

[lezama]

let's merge it!

[simison]

Tested in Calypso-Gutenberg: works well apart from expected "Jed localization error: Error: Domain jetpack was not found."

Tested in Jetpack-Gutenberg: works great, tested changing block title to "Settings" and I could see it translated to Finnish.

Tested exporting translation strings in Jetpack by npx gulp languages:extract — I can see the script looking into block files but I didn't see it pick any strings to _inc/jetpack-strings.php file in Jetpack. Was this expected?

Noting also that the build bundle fails in latest Jetpack master and latest Gutenberg with some lodash error, but that seems unrelated to this PR. I removed all the other blocks except Markdown from the preview and this worked great. 👍

Code looks great, clever idea!

[simison]

Tested exporting translation strings in Jetpack by npx gulp languages:extract — I can see the script looking into block files but I didn't see it pick any strings to _inc/jetpack-strings.php file in Jetpack. Was this expected?

Tested again by building minified prod-versions by adding NODE_ENV=production to SDK command and now extracting strings works like a charm. 👍