2fa: Update to use upstream phone package again

[kraftbj]

Changes proposed in this Pull Request

• Updates Calypso to use upstream phone npm package again.

Originally, we forked the npm package because of slow updates, but the upstream package appears to be updating on a regular basis now.

Testing instructions

• Test adding 2fa with a phone number. Try using a newer phone number, like Vietnam +84 numbers that begin with prefixes found in Vietnam phone numbers not validating for 2FA #25163 (comment)
• Another example is the US +1 phone numbers that begin with 986 (ex. +1-986-555-1212)

Fixes #25163 and possibly others detailed in p4TIVU-98g-p2 but would need testing.

I'm thinking this may be a short-term stop-gap while reviewing if there is a better package to use where we wouldn't have to maintain it.

[matticbot]

Test live: https://calypso.live/?branch=update/phone-validation

[ghost]

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

[blowery]

Nice! Always glad to get back on the mainline for these things.

Looks like there are a couple tests that may need to be updated from this? Or maybe the return changed a bit?

[kraftbj]

I'm looking into it. Those numbers fail, but looking at the upstream, they should pass. Trying to verify how we make that check to verify we're not doing anything unexpected.

[akirk]

This should also fix Tunesian phone numbers, see pxLjZ-55p-p2

[liviopv]

@kraftbj is there any estimate of when this is going to be merged?

[yoavf]

@liviopv see #29740 - I think that's a better solution. I can merge after a review is done. Are you using the module elsewhere?

[akirk]

We're waiting for these PRs to be merged upstream:

• Fix for Myanmar mobile phone numbers AfterShip/phone#123
• Fix Greenland mobile prefix AfterShip/phone#124
• Argentina: fix length and prefix AfterShip/phone#125

[blowery]

Wow, those PRs upstream still have not landed.

[akirk]

Upstream has now moved again but we have a report about a still not fixed Brazilian area code in #35339

I think resyncing our fork, merging that PR from upstream early, and updating our dependency here to continue to use the fork is a viable next step?

[akirk]

The upstream package is now up to date and has also incorporated the latest Brazilian phone number changes (AfterShip/phone#154), so we can use upstream again.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~7668 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
site-blocks                +1789 B  (+0.7%)     +639 B  (+1.0%)
security                   +1789 B  (+0.4%)     +639 B  (+0.6%)
purchases                  +1789 B  (+0.2%)     +639 B  (+0.3%)
privacy                    +1789 B  (+0.8%)     +639 B  (+1.1%)
notification-settings      +1789 B  (+0.6%)     +639 B  (+0.8%)
me                         +1789 B  (+0.8%)     +639 B  (+1.1%)
help                       +1789 B  (+0.4%)     +639 B  (+0.6%)
happychat                  +1789 B  (+0.7%)     +639 B  (+1.0%)
concierge                  +1789 B  (+0.6%)     +639 B  (+0.9%)
checklist                  +1789 B  (+0.6%)     +639 B  (+0.8%)
account-close              +1789 B  (+0.6%)     +639 B  (+0.8%)
account                    +1789 B  (+0.6%)     +639 B  (+0.8%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1917 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
async-load-design-playground      +1789 B  (+0.1%)     +639 B  (+0.2%)
async-load-design-blocks          +1789 B  (+0.1%)     +639 B  (+0.1%)
async-load-design                 +1789 B  (+0.1%)     +639 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[simison]

There's now v2.4.0 BTW.

[akirk]

Thanks, tests still pass fine, so I've bumped the version.

[blowery]

Looks good to me! Thanks for getting us back on mainline.

[blowery]

@akirk I rebased this to pick up the lockfile change and bumped the version to 2.4.2. Could you give it a quick sanity check?

[akirk]

Sorry I am late but tests pass fine and I didn't see problems in the UI, so let's went.

[blowery]

Thanks, @akirk! It looked good on my end too.