Gutenberg: Add textdomain to Jetpack blocks #27680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
Jetpack
[Status] Needs Review
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a textdomain to our Jetpack blocks, allowing us to translate those strings in future versions of Jetpack.
Changes proposed in this Pull Request
jetpacktextdomain to any localization function instances in our Jetpack blocks.Testing instructions
Note that this currently won't make the blocks pick up translations, additional work will be needed there to allow this (in addition to what was done in Automattic/jetpack#9560).