Reader: Conform with GA page view expectations. #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially reported for tag pages, but some others were wrong as well. Fixed 'em all. To test, turn on analytics debugging with `localStorage.debug = 'calypso:analytics'` in the console, reload, and watch for page view and scroll events when using the app. You shouldn't see any actual ids in the paths, only placeholders. So /tag/foo turns into /tag/:slug, /read/blog/feed/1234 turns into /read/blog/feed/:feed_id, and so on.
blowery
added
the
[Status] Needs Review
|
To verify:
|
bluefuton
added
[Status] Ready to Merge
and removed
[Status] Needs Review
bluefuton
added a commit
that referenced
this pull request
Jan 22, 2016
Reader: Conform with GA page view expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially reported for tag pages, but some others were wrong as well. Fixed 'em all.
To test, turn on analytics debugging with
localStorage.debug = 'calypso:analytics'in the console, reload, and watch for page view and scroll events when using the app.You shouldn't see any actual ids in the paths, only placeholders. So /tag/foo turns into /tag/:slug, /read/blog/feed/1234 turns into /read/blog/feed/:feed_id, and so on.