Reader: make the unauthorized error message appear below the "Oops!" heading #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
designsimply
added
[Status] Needs Review
| @@ -16,13 +16,13 @@ var PostUnavailable = React.createClass( { | |||
|
|
|||
| componentWillMount: function() { | |||
| this.errors = { | |||
| 403: this.translate( 'This is a private site. You’re following the site, but not currently a member. Please request membership to display these posts in Reader.' ), | |||
| 'unauthorized': this.translate( 'This is a private site. You’re following the site, but not currently a member. Please request membership to display these posts in Reader.' ), | |||
There was a problem hiding this comment.
While we're here, maybe change this to "this post" from "these posts" since the error applies to one post?
Also fix up the wording a bit and default to the default message if a code is passed, but we don't have a message for it.
blowery
force-pushed
the
fix/oops-for-unauthorized-reader-views
branch
from
1bdccf2
to
01c870b
Compare
|
👍 will ship it. I made some minor changes to make it even more robust and fixed the wording. Still your commit though. congrats @designsimply, nice work! |
blowery
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Thanks! /ht @bluefuton for help and explanations along the way too!! |
blowery
added a commit
that referenced
this pull request
Jan 22, 2016
…ader-views Reader: make the unauthorized error message appear below the "Oops!" heading
|
Nice one, Sheri! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to make the unauthorized error message appear below the "Oops!" heading as it should when someone tries to view a post in the Reader for a private site they are not authorized to see.
See 8753-gh-calypso-pre-oss for testing steps.
Before:
After:
or with
"reader/full-errors": true(i.e. local Calypso install)