Framework: Use an eslintrc with a specific format #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowery
added
Framework
[Status] Needs Review
| 'vars-on-top': 1, | ||
| 'yoda': 0 | ||
| } | ||
| } |
|
🚢 |
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Prior we were using an .eslintrc, which is supposed to be either JSON or YAML. This is now deprecated, in favor of .eslintrc., like .eslintrc.js for JavaScript. See http://eslint.org/docs/user-guide/configuring#using-configuration-files for more details. This patch moves to an .eslintrc.js and alters the format a bit to export the configuration object as the default, as per the config guide.
who will lint the linters?
blowery
force-pushed
the
fix/eslint-config-file
branch
from
92d1d74
to
1bd1800
Compare
blowery
added a commit
that referenced
this pull request
Feb 2, 2016
Framework: Use an eslintrc with a specific format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior we were using an .eslintrc, which is supposed to be either JSON or YAML. This is now deprecated, in favor of .eslintrc., like .eslintrc.js for JavaScript. However, our config has comments in it, which are not legal JSON, so we should really move to the JS format.
See http://eslint.org/docs/user-guide/configuring#using-configuration-files for more details.
This patch moves to an .eslintrc.js and alters the format a bit to export the configuration object as the default, as per the config guide.