Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads: Turn on JP support for Desktop App #2638

Merged
merged 1 commit into from
Jan 21, 2016

Conversation

dbspringer
Copy link
Member

”manage/ads/jetpack": true was omitted from the desktop config, turning the feature on for our Desktop users too :)

@dbspringer dbspringer added [Feature] WordPress Desktop App Features and improvements related to the WordPress Desktop App. WordAds labels Jan 20, 2016
@dbspringer dbspringer self-assigned this Jan 20, 2016
@dbspringer dbspringer added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2016
@blowery
Copy link
Contributor

blowery commented Jan 21, 2016

👍

@blowery blowery added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 21, 2016
@johnHackworth
Copy link
Contributor

🚢 !

@johnHackworth
Copy link
Contributor

oh, @blowery was quicker than me :D

dbspringer added a commit that referenced this pull request Jan 21, 2016
@dbspringer dbspringer merged commit 2085b6b into master Jan 21, 2016
@dbspringer dbspringer deleted the update/wordads-jetpack-desktop branch January 21, 2016 17:12
@blowery
Copy link
Contributor

blowery commented Jan 21, 2016

screenshot

@dbspringer
Copy link
Member Author

🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] WordPress Desktop App Features and improvements related to the WordPress Desktop App. WordAds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants