Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicity import react-dom with require statement #2597

Merged
merged 3 commits into from
Jan 26, 2016
Merged

Explicity import react-dom with require statement #2597

merged 3 commits into from
Jan 26, 2016

Conversation

garronmichael
Copy link
Contributor

Files changed: 1

hello-world.md

clarify that react-dom must be imported

  • When I was following the Hello, World! Calypso Guide, there are no explicit instructions to import react-dom. This clarification will save future users time since they will not attempt to debug correct code that is only missing an external dependency as I did.

@garronmichael
Copy link
Contributor Author

Before

screen shot 2016-01-19 at 3 23 14 pm

After

screen shot 2016-01-19 at 3 25 28 pm

@lancewillett lancewillett added OSS Citizen [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 20, 2016
@gwwar gwwar added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 26, 2016
@gwwar
Copy link
Contributor

gwwar commented Jan 26, 2016

@garronmichael Thanks for the catch!

gwwar added a commit that referenced this pull request Jan 26, 2016
@gwwar
Merge pull request #2597 from garronmichael/update/explicitly-import-…
ee9a35a 
…react-dom

Explicity import react-dom with require statement
@gwwar gwwar merged commit ee9a35a into Automattic:master Jan 26, 2016
@anarh anarh mentioned this pull request Feb 18, 2021
Open
@mdno mdno mentioned this pull request Feb 19, 2021
Open
@awaisab172 awaisab172 mentioned this pull request Feb 19, 2021
Open
@ajesse11x ajesse11x mentioned this pull request Feb 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OSS Citizen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garronmichael @gwwar @lancewillett @scruffian