Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invites: Launch accept invites to horizon and staging #2543

Merged
merged 1 commit into from
Jan 19, 2016

Conversation

ebinnion
Copy link
Contributor

As we gear up to launch the new accept invite functionality, we are going to do another round of testing.

This PR launches the accept invite functionality in staging and in horizon.

To test:

  • Checkout update/invites-config-to-stage branch
  • In horizon.json, stage.json, production.json... make sure that wpcom_user_bootstrap is false
  • In terminal, CALYPSO_ENV={environment} make run

cc @lezama

@ebinnion ebinnion added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. People Management labels Jan 18, 2016
@ebinnion ebinnion self-assigned this Jan 18, 2016
@ebinnion ebinnion added this to the People Management: m6 milestone Jan 18, 2016
@@ -85,7 +85,8 @@
"settings/security/monitor": true,
"settings/security/scan": false,
"ad-tracking": false,
"perfmon": true
"perfmon": true,
"accept-invite": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we try to avoid trailing , on the last item of json objects

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually!

image

😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blah. Thanks

@lezama lezama added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 18, 2016
@ebinnion ebinnion force-pushed the update/invites-config-to-stage branch from 7726402 to 655311d Compare January 18, 2016 21:03
@ebinnion ebinnion added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels Jan 18, 2016
@roccotripaldi
Copy link
Member

LGTM! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants