-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans: Add a/b test with 'upgrade' button in the sidebar #2453
Conversation
planName = 'Upgrade'; // TODO: translate this string if the test is removed | ||
} else { | ||
labelClass = 'plan-name'; | ||
} | ||
|
||
if ( productsValues.isFreeTrial( site.plan ) ) { | ||
planName = this.translate( 'Trial' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noted that on my todo list but since you're updating this file could you add more context to this translation? I guess just explaining it's for free trials for plans would really help translators to deliver a more accurate translation.
A quick note that |
Tested and works as described. 👍
Definitely something to keep an eye on. I will note that it does appear to handle this pretty well right now and (while still not being ideal) at least doesn't break the layout: |
462baec
to
a228c89
Compare
Thanks for looking at this, @breezyskies and @stephanethomas. I updated the commit to add context to the 'Trial' translation string and made the logic for using the button a bit more clear. |
Code looks good. We're good to go here. |
a228c89
to
1f74785
Compare
Plans: Add a/b test with 'upgrade' button in the sidebar
Fixes #2382.
This adds an a/b test to change the label in the sidebar next to 'Plans' from 'Free' to a button with the label 'Upgrade'.
original
variation:button
variation:I'll update the datestamp for this test before merging to the current day.
Testing
original
:localStorage.setItem( 'ABTests', '{"plansUpgradeButton_20040114":"original"}' );
in the console./stats/year/:site
(or any 'My Sites' route) for a site with the free plan.original
:localStorage.setItem( 'ABTests', '{"plansUpgradeButton_20040114":"button"}' );
in the console./stats/year/:site
(or any 'My Sites' route) for a site with the free plan.cc @breezyskies