Themes: replace infinite-list with infinite-scroll #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seear
added
[Type] Question
[Feature Group] Appearance & Themes
seear
changed the title
seear
added
[Status] Needs Review
|
This PR fires no fewer analytics events than |
|
Benefits of merging this PR to stop using InfiniteList.
|
seear
force-pushed
the
try/themes-infinite-scroll
branch
from
f5a2ce0 to
84dba29
Compare
|
I think this works well. Tested on Chrome and Chrome mobile, the scrolling is much smoother. Code LGTM 👍 |
Use the infinite-scroll mixin for showcase scrolling, which suits showcase needs better than infinite-list. Benefits over Infinite-List when used in the showcase: * scroll performance improvement over master when scrolling up and once all themes are rendered (optimising the <Theme /> render may cure problems when rendering new themes) * InfiniteScroll is vastly less complex than InfiniteList * Unlike InfiniteList, InfiniteScroll should render on the server without modification * InfiniteScroll does not need the number of items per row to be calculated
seear
force-pushed
the
try/themes-infinite-scroll
branch
from
f3e505c to
77ef864
Compare
seear
added a commit
that referenced
this pull request
Jan 7, 2016
Themes: replace infinite-list with infinite-scroll
scruffian
removed
the
[Status] Needs Review
This was referenced Jan 8, 2016
This was referenced Jan 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow some comparisons between infinite-list and infinite-scroll with regards to complexity and performance.
No loading placeholders rendered yet.Todo:
lastPageprop into<ThemesList />