Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Show chat notification when chat ends. #1591

Closed
wants to merge 3 commits into from

Conversation

omarjackman
Copy link
Contributor

Show chat notification when chat ends

This pull request aims at letting the user know that the olark operator has ended the chat and that they will be receiving a transcript. Prior to this the user had no indication that the chat has ended.

How to test

  1. Navigate to http://calypso.localhost:3000/help/contact
  2. Start a chat.
  3. Have the operator end the chat using the !end command.
  4. Notice the notification in the chat box

What to expect

screen shot 2015-12-15 at 9 31 49 pm

screen shot 2015-12-15 at 9 34 08 pm

noting here that there are some CSS issues that I intend to fix in a future pull request. this line of code seems to be causing some weird wrapping if the user decides to start chatting after a notification.

Fixes #1341

@omarjackman omarjackman added [Status] In Progress Live Chat [Feature Group] Support All things related to WordPress.com customer support. labels Dec 15, 2015
@omarjackman omarjackman self-assigned this Dec 15, 2015
@omarjackman omarjackman force-pushed the update/show-notification-on-chat-end branch from 4b9dba3 to 29c3dea Compare December 15, 2015 07:00
@omarjackman omarjackman force-pushed the update/show-notification-on-chat-end branch from 29c3dea to e34d9d3 Compare December 16, 2015 01:44
@omarjackman omarjackman force-pushed the update/show-notification-on-chat-end branch from e34d9d3 to df8a382 Compare December 16, 2015 02:42
@omarjackman omarjackman added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Dec 16, 2015
@omarjackman
Copy link
Contributor Author

cc @dmsnell @dllh

@dllh
Copy link
Member

dllh commented Dec 16, 2015

The interaction here is still a little weird if I'm the last available operator. In my test, I was the only operator in the group and had hit my chat maximum, so when I accepted the chat, my status was set to away, and thus I was away when I ended the chat. My test user wound up seeing the Sorry! We just missed you as our Happiness Engineers stepped away. notice, and the screen rendered the offline contact form with the chat box at bottom right. The chat box did show the "Your live chat has ended" message, and then the box went away after a few seconds (didn't capture this last bit in the screen grab below). I sort of expected to just see the message in the inline chat box as pictured above.

When I increase my max chats threshold so that I'm not away when I end the chat (meaning: an operator in the group is still available when I end the chat), the interaction works as expected, with the message displayed in the inline chat box.

chat-end

Is this a case we can fix? Hopefully, most users won't be affected, but depending on staffing, it seems not too unlikely that users could see a chat ended with no other opers available and wind up having this interaction.

@dllh dllh added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 16, 2015
@dllh dllh added this to the Help: v1 milestone Dec 17, 2015
@omarjackman
Copy link
Contributor Author

Is this a case we can fix? Hopefully, most users won't be affected, but depending on staffing, it seems not too unlikely that users could see a chat ended with no other opers available and wind up having this interaction.

#1714 will fix this as well as fix #1340

@omarjackman
Copy link
Contributor Author

Since #1340 and #1341 are variations of the same issue I am closing this PR and starting over with #1714 that aims to fix them all in a nicer way.

@lancewillett lancewillett deleted the update/show-notification-on-chat-end branch January 14, 2016 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Support All things related to WordPress.com customer support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help: Ending a chat while a user is on /help/contact is a jarring experience.
3 participants