-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help: Show chat notification when chat ends. #1591
Conversation
4b9dba3
to
29c3dea
Compare
29c3dea
to
e34d9d3
Compare
e34d9d3
to
df8a382
Compare
The interaction here is still a little weird if I'm the last available operator. In my test, I was the only operator in the group and had hit my chat maximum, so when I accepted the chat, my status was set to away, and thus I was away when I ended the chat. My test user wound up seeing the When I increase my max chats threshold so that I'm not away when I end the chat (meaning: an operator in the group is still available when I end the chat), the interaction works as expected, with the message displayed in the inline chat box. Is this a case we can fix? Hopefully, most users won't be affected, but depending on staffing, it seems not too unlikely that users could see a chat ended with no other opers available and wind up having this interaction. |
Show chat notification when chat ends
This pull request aims at letting the user know that the olark operator has ended the chat and that they will be receiving a transcript. Prior to this the user had no indication that the chat has ended.
How to test
!end
command.What to expect
noting here that there are some CSS issues that I intend to fix in a future pull request. this line of code seems to be causing some weird wrapping if the user decides to start chatting after a notification.
Fixes #1341