Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export: enable in desktop app #15003

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Export: enable in desktop app #15003

merged 1 commit into from
Jun 13, 2017

Conversation

seear
Copy link
Contributor

@seear seear commented Jun 12, 2017 •
edited
Loading

Fixes https://github.com/Automattic/wp-desktop/issues/306

Enable the export feature on the Desktop app.

export

Works fine. The only slight oddity is that the download link downloads the file in the system default browser instead of the app.

To Test

  • Build the desktop app with this PR
  • Go to Site Settings->General->Site Tools->Export
  • Export site contents

@seear seear added [Feature] WordPress Desktop App Features and improvements related to the WordPress Desktop App. Export [Feature] Site Settings All other general site settings. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 12, 2017
@seear seear self-assigned this Jun 12, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/export-desktop

@matticbot matticbot added the [Size] S Small sized issue label Jun 12, 2017
@seear
Copy link
Contributor Author

seear commented Jun 12, 2017

@dllh Any reason why export was not already enabled in the desktop app?

@dllh
Copy link
Member

dllh commented Jun 12, 2017

I don't recall a reason and can't think of one now, unless there's anything weird in how the app would deal with an external link to the download (which seems unlikely).

@seear seear requested a review from dllh June 12, 2017 15:58
@seear
Copy link
Contributor Author

seear commented Jun 12, 2017

I don't recall a reason and can't think of one now, unless there's anything weird in how the app would deal with an external link to the download (which seems unlikely).

Thanks. The download happens in system browser rather than the app, which is a bit weird, but normal I think.

@seear
Copy link
Contributor Author

seear commented Jun 12, 2017

which is a bit weird

...and doesn't seem like a reason to keep it disabled.

@seear seear requested a review from tyxla June 13, 2017 08:55
tyxla
tyxla approved these changes Jun 13, 2017
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@tyxla tyxla added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 13, 2017
@seear seear merged commit 99c1a24 into master Jun 13, 2017
@seear seear deleted the add/export-desktop branch June 13, 2017 09:01
@astralbodies
Copy link
Contributor

Cherry picked this into release/desktop/2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@dllh dllh Awaiting requested review from dllh

Assignees

@seear seear

Labels
Export [Feature] Site Settings All other general site settings. [Feature] WordPress Desktop App Features and improvements related to the WordPress Desktop App. [Size] S Small sized issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seear @matticbot @dllh @astralbodies @tyxla