Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain Management: Use flexbox for DNS records and update delete button to use Gridicon #1467

Merged
merged 1 commit into from
Dec 14, 2015
Merged

Domain Management: Use flexbox for DNS records and update delete button to use Gridicon #1467

merged 1 commit into from
Dec 14, 2015

Conversation

breezyskies
Copy link
Contributor

This is a second attempt at #1277, which had to be reverted due to the remove of the RemoveButton component.

  • Converts floats to flexbox for DNS editor
  • Updates the delete button to standard styling

cc: @gziolo @mtias

@breezyskies breezyskies added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Dec 10, 2015
@breezyskies breezyskies self-assigned this Dec 10, 2015
@gziolo gziolo added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 14, 2015
@gziolo
Copy link
Member

gziolo commented Dec 14, 2015

Still looking good.

breezyskies added a commit that referenced this pull request Dec 14, 2015
@breezyskies
Merge pull request #1467 from Automattic/fix/dns-editor-take2
f23e8ac 
Domain Management: Use flexbox for DNS records and update delete button to use Gridicon
@breezyskies breezyskies merged commit f23e8ac into master Dec 14, 2015
@breezyskies breezyskies deleted the fix/dns-editor-take2 branch December 14, 2015 14:12
This was referenced Sep 15, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@breezyskies breezyskies

Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@breezyskies @gziolo @scruffian