Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades: fix right alignment in cancel privacy #1461

Merged
merged 1 commit into from
Dec 11, 2015

Conversation

dzver
Copy link
Member

@dzver dzver commented Dec 10, 2015

The cancel privacy page is incorrectly using a right-aligned style created for another page. It adds nothing to the look other than right alignment on mobile.

To test (on mobile):

  1. Go to purchases and select a domain name with privacy.
  2. Click Cancel Privacy
  3. The page should not be right-aligned.

@dzver dzver added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Dec 10, 2015
@dzver dzver self-assigned this Dec 10, 2015
@@ -144,7 +144,7 @@ const CancelPrivateRegistration = React.createClass( {

return (

<Main className="manage-purchase__detail">
<Main>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, red code fixes are the best fixes.

@mtias mtias added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 10, 2015
dzver pushed a commit that referenced this pull request Dec 11, 2015
…gnment

Upgrades: fix right alignment in cancel privacy
@dzver dzver merged commit bc9f4a3 into master Dec 11, 2015
@dzver dzver deleted the fix/private-registration-alignment branch December 11, 2015 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants