-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publicize: add sharing preview modal #12679
Publicize: add sharing preview modal #12679
Conversation
* add this util helper used for the get-post-share-published-actions and get-post-share-scheduled-actions selectors
c64d495
to
d8ff123
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jhnstn changes here look good and test well
<Gridicon icon="cross" /> | ||
</button> | ||
</header> | ||
<SharingPreviewPane { ...previewProps } /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is optional, but if we're concerned with pass through props, perhaps:
{ children }
So in the caller this looks like:
<SharingPreviewModal isVisible={ isVisible } onClose={ onClose }>
<SharingPreviewPane siteId={ siteId } postId={ postId } message={ message } />
</SharingPreviewModal>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we pull out the sharing specific props, this component becomes reusable if we need a dialog that looks like a web preview. (We'd need to change class names though and move this into the component folder.)
125acee
to
d06d942
Compare
@jhnstn This PR needs a rebase |
d06d942
to
fcd4b59
Compare
closing in favor of #12753 |
This adds a preview modal to publicize:
breakpoint > 660px
breakpoint < 660px
Note
At the moment we only have previews for Facebook and Twitter. #12644 adds the remaining available services.
Testing