Fix: keyboard clicks on gaps. also es6ify #12604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
added
[Feature] Reader
samouri
force-pushed
the
fix/reader/keyboard-gaps
branch
from
0ea2aa9 to
da02249
Compare
|
Hopefully this is the only thing I broke 🤞 |
samouri
added
[Status] Needs Review
blowery
approved these changes
Mar 29, 2017
blowery
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR broke keyboard shortcuts for gaps (#11618)
This PR seeks to both fix that issue and give the
list-gapcomponent a facelift.To Test: