RemoveButton: Remove focus borders inherited from Button component #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alternatekev
added
[Status] Needs Review
alternatekev
force-pushed
the
update/removebutton-outline
branch
from
17022f8
to
5b8940e
Compare
|
I can't replicate the :active effect we were seeing on the Email Forwarding screen with the devdocs version of the components, but when we merge #1199 this will fix it. |
alternatekev
added
[Status] Needs Review
breezyskies
force-pushed
the
update/removebutton-outline
branch
from
5b8940e
to
b538e02
Compare
|
Rebased and tested. LGTM 👍 |
breezyskies
added
[Status] Ready to Merge
and removed
[Status] Needs Review
alternatekev
added a commit
that referenced
this pull request
Dec 4, 2015
RemoveButton: Remove focus borders inherited from Button component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1199, @breezyskies noticed that the RemoveButton has some hover and active states specifying a border to them, which this component doesn't need. This PR removes them.