Signup: DSS: Render DssScreenshot with pure props #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirbrillig
added
[Status] Needs Review
Removes the dependence on stores within DssScreenshot
sirbrillig
force-pushed
the
update/dss-use-props-for-screenshot
branch
from
c269f86 to
0e20b77
Compare
|
Ping @kwight for review |
|
LGTM 👍 |
kwight
added
[Status] Ready to Merge
and removed
[Status] Needs Review
sirbrillig
added a commit
that referenced
this pull request
Dec 4, 2015
…eenshot Signup: DSS: Render DssScreenshot with pure props
This was referenced Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the dependence on stores within
DssScreenshot.Depends on #1195
Testing
Load http://calypso.localhost:3000/start/dss/ and try searching for words. Make sure that the images load correctly.