Menus: fix randomly closing item edit view #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seear
added
Menus
[Status] Needs Review
|
The code LGTM, and I've tested moving/saving/adding/editing. All works. Perhaps we should loop @mcsf in to have a quick look? |
|
This looks good so far. Killing My only remark would be that we're using the term |
Yeah, good point. Fixed in d95056c |
Observing `sites` in menus/main.jsx forces a re-render whenever `sites` changes. When this happens, the edit-tracking `lock` object is created anew, causing any currently open item edit box to close. This change removes the use of the lock lib entirely, using state to track the currently edited item.
seear
force-pushed
the
fix/menu-edit-rerender
branch
from
d95056c
to
9c8dc91
Compare
seear
added a commit
that referenced
this pull request
Dec 3, 2015
Menus: fix randomly closing item edit view
scruffian
removed
the
[Status] Needs Review
|
Thanks for fixing this! Was annoying me earlier this week and I came to report it to find a merged PR. Boom. 💯 |
This was referenced Jul 16, 2020
This was referenced Nov 18, 2020
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observing
sitesin menus/main.jsx forces a re-render wheneversiteschanges.When this happens, the edit-tracking
lockobject is created anew, causing any currentlyopen item edit box to close.
This change removes the use of the lock lib entirely, using state to track
the currently edited item.
To Reproduce
3) The edit view will open for the item 4) Wait a while, and the edit view will close on its ownTo Test
With this PR, all menus behaviour should be the same, except for the edit view closing on its own