Update/node-modules html-loader, json-loader, imports-loader #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lancewillett
added
Build
[Status] Needs Review
|
do you happen to know if we use the html-loader for anything? |
Not much, but for fun I tried webpack without it and it choked on a file inside the ERROR in ./~/component-tip/template.html
Module parse failed: /Users/robertralian/Projects/wp-calypso/node_modules/component-tip/template.html Line 1: Unexpected token <
You may need an appropriate loader to handle this file type.
| <div class="tip tip-hide">
| <div class="tip-arrow"></div>
| <div class="tip-inner"></div>
@ ./~/component-tip/index.js 14:18-44
webpack: bundle is now VALID. |
|
They're not much for changelogs are they? I did some sanity testing running in different environments and am seeing no problems. 👍 |
rralian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
artpi
added a commit
that referenced
this pull request
Dec 18, 2015
Update/node-modules html-loader, json-loader, imports-loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
make runThere shouldnt be any build errors