Me: Fixes logic for holiday snow date gate #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Status] Needs Review
lezama
added
[Status] Ready to Merge
and removed
[Status] Needs Review
ebinnion
added a commit
that referenced
this pull request
Dec 2, 2015
…gate Me: Fixes logic for holiday snow date gate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1138, I added the holiday snow checkbox on the
/me/accountroute. Unfortunately, my date math didn't properly handle showing the checkbox for the beginning of the year. 😁This PR fixes that and simplifies attempts to simplify some of the logic.
cc @Viper007Bond who pointed out my logic issue in the previous PR.
To test:
update/me-holiday-snow$site/wp-admin/options-general.phpand ensure holiday snow is turned on/me/account