Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain Management: DNS: Minor improvements to SRV Record form #1121

Closed
wants to merge 2 commits into from

Conversation

rads
Copy link
Contributor

@rads rads commented Dec 1, 2015

  • Fix a bug where the form would return a server-side error if the Protocol select box was left in it's default state.
  • Change the "Value" field to "Name" to make the purpose more clear.

Testing

  1. Go to http://calypso.localhost:3000/domains/manage
  2. Click on a domain registration or mapping and select "DNS Editor"
  3. Try to add a SRV record but do not change the Protocol option
  4. The SRV record should get added successfully.

@rads rads added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Dec 1, 2015
@rads rads self-assigned this Dec 1, 2015
@rads
Copy link
Contributor Author

rads commented Dec 1, 2015

This is actually a duplicate of #1010.

@rads rads closed this Dec 1, 2015
@rads rads removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 1, 2015
@lancewillett lancewillett deleted the fix/domain-management-srv-protocol branch December 22, 2015 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant