Site Settings: Separate Composing in a separate component #11192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Feature] Site Settings
55 tasks
roccotripaldi
approved these changes
Feb 6, 2017
roccotripaldi
added
[Status] Ready to Merge
and removed
[Status] Needs Review
tyxla
force-pushed
the
update/site-settings-composing-separate-component
branch
from
37b42c6 to
e49717f
Compare
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Composing card to a separate component. This will allow us to add more settings without driving the writing form component grow too large. There are no functional changes, this PR only prepares the card for adding more settings that are specific to Jetpack sites.
This PR is part of #9171.
To test:
/settings/writing/$sitefor a Jetpack site./settings/writing/$sitefor a WordPress.com site.