Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Settings: changed the language of the Google Analytics help text #1117

Merged
merged 1 commit into from
Dec 1, 2015
Merged

Site Settings: changed the language of the Google Analytics help text #1117

merged 1 commit into from
Dec 1, 2015

Conversation

rickybanister
Copy link

The help text now mentions the Tracking ID instead of the code which confusingly refers to the Google Analytics javascript snippet.

To test:

  • Switch to a site with a Business upgrade
  • Visit /settings/analytics/site
  • Verify the language change
  • Click the link and read Google's documentation, the reference to 'tracking ID' and 'code' will now be more in line with what we require in our form.

Before:
screen shot 2015-12-01 at 10 59 49 am

After:
screen shot 2015-12-01 at 11 08 56 am

Site Settings: changed the language of the Google Analytics help text…
0b10235 
… to mention the tracking ID instead of the 'code' which confusingly refers to the Google Analytics javascript snippet
@rickybanister rickybanister added [Feature] Site Settings All other general site settings. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2015
@rickybanister rickybanister self-assigned this Dec 1, 2015
@folletto
Copy link
Contributor

folletto commented Dec 1, 2015

Seems clearer to me: 👍

@alternatekev
Copy link
Contributor

LGTM 👍

@alternatekev alternatekev added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2015
rickybanister pushed a commit that referenced this pull request Dec 1, 2015
Merge pull request #1117 from Automattic/update/analytics-help-link
579046a 
Site Settings: changed the language of the Google Analytics help text
@rickybanister rickybanister merged commit 579046a into master Dec 1, 2015
@rickybanister rickybanister deleted the update/analytics-help-link branch December 1, 2015 17:31
@ajesse11x ajesse11x mentioned this pull request Nov 4, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Nov 5, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 25, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rickybanister rickybanister

Labels
[Feature] Site Settings All other general site settings.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickybanister @folletto @alternatekev @scruffian