Add timezones selectors and tests #11131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrofox
changed the title
retrofox
force-pushed
the
update/timezones-state-selectors
branch
from
6bf1cfa to
8e6442f
Compare
retrofox
force-pushed
the
update/timezones-state-selectors
branch
from
8e6442f to
3b3e1e3
Compare
retrofox
added
State
[Status] Needs Review
gwwar
approved these changes
Feb 8, 2017
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import { isRequestingTimezones } from '../'; |
There was a problem hiding this comment.
We can go ahead and delete this file, since we're using the data/http layer and don't store this state explicitly
| it( 'should return null if `timezones` aren\'t synced', () => { | ||
| const state = { | ||
| timezones: { | ||
| rawOffsets: [], |
There was a problem hiding this comment.
I believe this should be an object
| timezones: { | ||
| rawOffsets: [], | ||
| byContinent: {}, | ||
| requesting: null |
There was a problem hiding this comment.
We can remove any requesting props from mock data
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
retrofox
force-pushed
the
update/timezones-state-selectors
branch
from
3b3e1e3 to
11adead
Compare
retrofox
force-pushed
the
update/timezones-state-selectors
branch
from
11adead to
b483bc3
Compare
retrofox
force-pushed
the
update/timezones-state-selectors
branch
from
b483bc3 to
b691847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #10934.This PR add timezones selectors and also add tests for all of them.
Testing
Run client tests
state selectors