Invites: move /accept-invite to /my-sites/invites #1108
Conversation
| import InviteHeader from './invite-header'; | ||
| import LoggedInAccept from './logged-in-accept'; | ||
| import LoggedOutInvite from './logged-out-invite'; | ||
| import InviteHeader from 'components/invites/invite-header'; |
There was a problem hiding this comment.
We should avoid app-components in client/components (purer UI components). I'd place invite react components in "my-sites".
lezama
force-pushed
the
update/move-accept-invite-to-invites
branch
from
7a88e41 to
7bc488c
Compare
lezama
changed the title
lezama
force-pushed
the
update/move-accept-invite-to-invites
branch
3 times, most recently
from
3b6e5f9 to
a8775f5
Compare
lezama
added
[Status] Needs Review
| @@ -177,6 +172,11 @@ | |||
| @import 'my-sites/draft/style'; | |||
| @import 'my-sites/drafts/style'; | |||
| @import 'my-sites/exporter/style'; | |||
| @import 'my-sites/invites/invite-form-header/style'; | |||
| @import 'my-sites/invites/invite-header/style'; | |||
| @import 'my-sites/invites/invite-accept/logged-in/style'; | |||
There was a problem hiding this comment.
the logged-in / logged-out things should be prefixed or become sub-components.
There was a problem hiding this comment.
Aren't they sub-components?
There was a problem hiding this comment.
A subcomponent is invite-accept/logged-in.jsx, the folder logged-in is a full component.
There was a problem hiding this comment.
So, to clarify, we either need to bring the logged-in and logged-out into the my-sites/invites directory, or do the sub-components?
lezama
force-pushed
the
update/move-accept-invite-to-invites
branch
from
a8775f5 to
06d3b40
Compare
|
Code wise, you already addressed my comment it looks like. Functionally, this works fine. In testing, I found a few bugs, but I don't believe those to be related to this PR and I have created separate issues for them.
|
ebinnion
added
[Status] Ready to Merge
and removed
[Status] Needs Review
…-invites Invites: move /accept-invite to /my-sites/invites
How to test
Everything in the invite process should still flow.
update/move-accept-invite-to-inviteshttp://calypso.dev:3000/accept-invite/<blog_id>/<invitation_id>Closes #1101