Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented: Remove @TODO from Jetpack REST API methods #10612

Merged
merged 1 commit into from
Jan 16, 2017

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jan 13, 2017

This PR removes the @TODO comments from all Jetpack REST API methods that we introduced recently. I've manually tested all of them and confirmed that they're working properly.

Testing them requires you to manually call each method, directly or not - some of these are implemented in query components, and some of them are being used in #9802 and #10083, which can be used for testing as well.

@tyxla tyxla added Jetpack [Feature] Site Settings All other general site settings. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 13, 2017
@tyxla tyxla added this to the Jetpack Module Settings in Calypso milestone Jan 13, 2017
@tyxla tyxla self-assigned this Jan 13, 2017
@matticbot
Copy link
Contributor

@oskosk
Copy link
Contributor

oskosk commented Jan 13, 2017

:shipit:

@oskosk oskosk added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 13, 2017
@tyxla tyxla merged commit 41cf909 into master Jan 16, 2017
@tyxla tyxla deleted the update/test-new-jetpack-rest-api-undocumented-methods branch January 16, 2017 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Settings All other general site settings. Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants