Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Settings: Add more tests for isFetchingModules() selector #10318

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Jetpack Settings: Add more tests for isFetchingModules() selector #10318

merged 1 commit into from
Jan 4, 2017

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Dec 29, 2016 •
edited by artpi
Loading

This PR is part of #9171 and it adds 2 additional tests for the isFetchingModules() selector that cover the following cases:

  • When the modules are not being fetched
  • When the site is not known.

To test:

  • Checkout this branch
  • Run the following in your console:
npm run test-client client/state/jetpack-settings/modules/test/selectors.js -- --grep "isFetchingModules"
  • Verify all tests pass ✅ .

@tyxla tyxla added Jetpack [Feature] Site Settings All other general site settings. State [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 29, 2016
@tyxla tyxla added this to the Jetpack Module Settings in Calypso milestone Dec 29, 2016
@tyxla tyxla self-assigned this Dec 29, 2016
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/more-jetpack-settings-modules-isfetchingmodules-tests

@oskosk
Copy link
Contributor

oskosk commented Jan 3, 2017

LGTM

@oskosk oskosk added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 3, 2017
@tyxla tyxla force-pushed the add/more-jetpack-settings-modules-isfetchingmodules-tests branch from 2bc9e75 to 23ccdc0 Compare January 4, 2017 07:27
@tyxla tyxla merged commit b9e0cdd into master Jan 4, 2017
@tyxla tyxla deleted the add/more-jetpack-settings-modules-isfetchingmodules-tests branch January 4, 2017 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryelle ryelle Awaiting requested review from ryelle

@oskosk oskosk Awaiting requested review from oskosk

@johnHackworth johnHackworth Awaiting requested review from johnHackworth

@roccotripaldi roccotripaldi Awaiting requested review from roccotripaldi

Assignees

@tyxla tyxla

Labels
[Feature] Site Settings All other general site settings. Jetpack State
Projects
None yet
Milestone
Jetpack Settings v1
Development

Successfully merging this pull request may close these issues.
3 participants
@tyxla @matticbot @oskosk