-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Settings: Convert checkboxes to toggles in the General tab #10229
Site Settings: Convert checkboxes to toggles in the General tab #10229
Conversation
This looks good to me but a few observations:
|
@oskosk the toggles were already approved from @rickybanister and @MichaelArestad in the other PR (#10209), so I think just a general design feedback is necessary on this one. |
Alirght!, then |
@oskosk is right about the functionality, but let's fix that in another PR. Looks good on design. |
Thanks for the quick review folks 👍 |
This PR refactors the existing general settings to use toggles instead of checkboxes (see #9171). Inspired by @ryelle's awesome work in #10167. This work was previously done in #10209, but I had to begin from scratch because 90% of what I did was done there was done in #9085 (which was recently merged).
Screenshots
Jetpack Site
WordPress.com site
To test
Also, test on WordPress.com sites (it contains Language and Site Timezone options, as well as a Private option for the Privacy setting):
/cc
@ryelle @oskosk @roccotripaldi @johnHackworth for code review
@rickybanister @MichaelArestad for design review