-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Settings: Implement bulk settings management into Redux #10123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
Jetpack
[Feature] Site Settings
All other general site settings.
[Status] In Progress
labels
Dec 16, 2016
tyxla
force-pushed
the
add/jetpack-settings-bulk-settings-redux
branch
from
December 23, 2016 12:33
70e54a8
to
4b68e1f
Compare
55 tasks
4 tasks
tyxla
added
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
and removed
[Status] In Progress
labels
Dec 28, 2016
Awesome! Works as described. @nylen returns tomorrow, let's see what he says on D3588 before we merge. |
oskosk
added
[Status] Ready to Merge
and removed
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
labels
Jan 3, 2017
🚢 |
+1 Ship it |
roccotripaldi
approved these changes
Jan 3, 2017
tyxla
force-pushed
the
add/jetpack-settings-bulk-settings-redux
branch
from
January 4, 2017 07:13
53ace01
to
d2c5de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR introduces actions, reducer and selectors for bulk managing (retrieving and updating) Jetpack module settings. Also, a query component for managing network requests for bulk module settings is being introduced. This PR is part of the Jetpack Module Settings group effort (#9171).
This PR will allow us to update module settings and activate/deactivate modules in a single request; also to read all module settings in a single request.
New WP.COM API methods
For interacting with the .com API it introduces 2 methods that are not yet implemented on the API side:
fetchJetpackSettings()
updateJetpackSettings()
In order to fully test these methods you can:
To test
QueryJetpackSettings
query component and verify it dispatches the proper network requests -<QueryJetpackSettings siteId={ 1234 } />
.npm run test-client client/state/jetpack-settings/settings/