Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Settings: Implement bulk settings management into Redux #10123

Merged
merged 12 commits into from
Jan 4, 2017

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Dec 16, 2016

Introduction

This PR introduces actions, reducer and selectors for bulk managing (retrieving and updating) Jetpack module settings. Also, a query component for managing network requests for bulk module settings is being introduced. This PR is part of the Jetpack Module Settings group effort (#9171).

This PR will allow us to update module settings and activate/deactivate modules in a single request; also to read all module settings in a single request.

New WP.COM API methods

For interacting with the .com API it introduces 2 methods that are not yet implemented on the API side:

  • fetchJetpackSettings()
  • updateJetpackSettings()

In order to fully test these methods you can:

To test

  • Checkout this branch
  • Play with the QueryJetpackSettings query component and verify it dispatches the proper network requests - <QueryJetpackSettings siteId={ 1234 } />.
  • Verify all tests are working: npm run test-client client/state/jetpack-settings/settings/

@tyxla tyxla added this to the Jetpack Module Settings in Calypso milestone Dec 16, 2016
@tyxla tyxla self-assigned this Dec 16, 2016
@matticbot
Copy link
Contributor

@tyxla tyxla force-pushed the add/jetpack-settings-bulk-settings-redux branch from 70e54a8 to 4b68e1f Compare December 23, 2016 12:33
@oskosk oskosk mentioned this pull request Dec 23, 2016
55 tasks
@tyxla tyxla added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Dec 28, 2016
@roccotripaldi
Copy link
Member

Awesome! Works as described.

@nylen returns tomorrow, let's see what he says on D3588 before we merge.

@oskosk oskosk added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 3, 2017
@oskosk
Copy link
Contributor

oskosk commented Jan 3, 2017

🚢

@roccotripaldi
Copy link
Member

+1 Ship it

@tyxla tyxla force-pushed the add/jetpack-settings-bulk-settings-redux branch from 53ace01 to d2c5de0 Compare January 4, 2017 07:13
@tyxla tyxla merged commit 1f50bd8 into master Jan 4, 2017
@tyxla tyxla deleted the add/jetpack-settings-bulk-settings-redux branch January 4, 2017 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Settings All other general site settings. Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants