Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler theme not respecting Site Title block alignment #94819

Closed
radtechgh opened this issue Sep 23, 2024 · 6 comments
Closed

Assembler theme not respecting Site Title block alignment #94819

radtechgh opened this issue Sep 23, 2024 · 6 comments
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Groundskeeping Issues handled through Dotcom Groundskeeping rotations Needs triage Ticket needs to be triaged [Pri] High Address as soon as possible after BLOCKER issues [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug

Comments

@radtechgh
Copy link

Quick summary

Site Title block alignment stuck to bottom. Top or Middle alignment is not respected. Other blocks added respect the Middle align, so the header looks out of alignment.

Steps to reproduce

  1. Premium test site.
  2. switched theme to Assembler
  3. Site Editor, edit header.
  4. Site Title block is in a Row block
  5. Set Alignment in Row block to Middle.
  6. Site Title remains aligned to bottom.

What you expected to happen

Site title block has space above, so it has room to adjust, it should change alignment when configured.

What actually happened

Site Title block remains fixed in Bottom Alignment.

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@radtechgh radtechgh added [Type] Bug Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels Sep 23, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Sep 23, 2024
@radtechgh
Copy link
Author

8771940-zen

@github-actions github-actions bot added the [Pri] High Address as soon as possible after BLOCKER issues label Sep 23, 2024
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 8771940-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 23, 2024
@allilevine
Copy link
Member

Adding screenshot:

Screen Shot 2024-09-23 at 10 11 20 AM

@allilevine allilevine moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Sep 23, 2024
@renatho renatho added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Sep 25, 2024
@renatho renatho self-assigned this Sep 25, 2024
@renatho
Copy link
Contributor

renatho commented Sep 25, 2024

I found out that installing the Assembler theme on a standalone site works properly. So searching for the differences, I noticed that one of the global styles is differently rendered in Calypso. If I fix this, it seems the error is fixed.

I didn't find the reason to render it differently yet, but I'm already sharing it here since I'll probably not finish it today.

Calypso site:
Screenshot 2024-09-25 at 15 11 55

Standalone site:
Screenshot 2024-09-25 at 15 11 32

@renatho
Copy link
Contributor

renatho commented Sep 25, 2024

@Automattic/lego 👋 Would you easily know the reason for this difference in Calypso? Maybe a filter somewhere?

@renatho
Copy link
Contributor

renatho commented Sep 26, 2024

After some debugging I found the reason and noticed that it was an issue introduced by this Gutenberg PR, but already fixed by this PR. So in the next Gutenberg update in WPCOM it will be fixed.

Since it's not related to Calypso repository and the solution was already merged in Gutenberg, I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Groundskeeping Issues handled through Dotcom Groundskeeping rotations Needs triage Ticket needs to be triaged [Pri] High Address as soon as possible after BLOCKER issues [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug
Development

No branches or pull requests

3 participants