Gutenberg: v10.4.x plugin upgrade

[fullofcaffeine]

Previous upgrade: #51161
Release notes: v10.4.0, v10.4.1

Process

• Install and activate
  • Copy & install v10.4.0-rc.1 (D59888-code, D59889-code)
  • Activate v10.4.0-rc.1 on edge (D59891-code)
  • Copy & install v10.4.0 (D60200-code, D60201-code)
  • Activate v10.4.0 on edge (D60203-code)
  • Activate v10.4.0 on production (D59893-code)
  • Copy & install v10.4.1 (D60253-code, D60254-code
  • Activate v10.4.1 on edge (D60255-code)
  • Activate v10.4.1 on production (D59893-code)
  • Request update for Atomic sites (p9o2xV-1m2-p2)
• Testing
  • Calypso E2E (Gutenberg: Run E2E suite against v10.4.1 #51769)
  • Team City (D59893-code)
• Publish internal announcements
• Clean up unused releases
• Add log entry to the Gutenberg Upgrade Log [pcoGjb-g-p2]
• Open a new issue for the next upgrade, transfer remaining tasks, close this issue.

Blockers 🙅‍♀️

• Latest Blocks block leak the content of password-protected posts

  • Slack context: p1618442395083900-slack-C7YPUHBB2

• Publishing is broken

  • Reported: p1618329923048900/1618275648.017700-slack-C7YPUHBB2
  • Further investigation: p1618359088062300-slack-C7YPUHBB2
  • Crash fix (not yet merged): Editor: Handle case where unavailable siteData is causing WSOD WordPress/gutenberg#30812
  • Root issue fix (solves crash, too): D60153-code

• Autocomplete perf issue

  • Reported: Components: Stop matching autocompleter upon mismatch WordPress/gutenberg#30649
  • Fix: Components: Stop matching autocompleter upon mismatch WordPress/gutenberg#30649

Other issues 🐛

• Classic: Infinite content duplication loop when wrapping with anchor tag #29338
  • Reported in: p1613735197155300/1613458151.107400-slack-CBTN58FTJ
• Reusable block can't be broken down into individual blocks, no specific root cause identified yet. Seems specific to using some blocks inside the reusable block, though it's not known yet at this time.
  • Reported in: p1614866772382300-slack-C7YPUHBB2
  • Seems to be fixed by: Fix reusable block crash when converting a just created reusable block to blocks. WordPress/gutenberg#29292
• Search block's button padding is broken
  • Reported here: Broken padding in Search block's button WordPress/gutenberg#29952

---

cc @inaikem

[Robertght]

Howdy! I'm getting this error when I try to publish a post on a simple site:

typeError: Cannot read property 'isBeingScheduled' of undefined
    at Mi (https://s0.wp.com/_static/??-eJylz1EOwiAMBuALWTqccXsxngVGs3QyWApsHl/mgweQx/ZPv/zFY4Mphkwh4+bLzCHhXOpoSeaaCOGuO3VTHcikNNrC3qEz2XzPJPqEHBy91ZIu+Bd27uEUW6GVHBsomds7CZVkrCewPk6vZi6R7CSQ2BEIVUtaxfpqjs3KznRsUfLPea4PfdfD2F/Hflg+VOS/YA==:28:591)
    at we (https://s0.wp.com/wp-content/plugins/gutenberg-core/v10.4.0-rc.1/vendor/react-dom.min.de439aae.js?m=1599596311h:8:293)
    at zj (https://s0.wp.com/wp-content/plugins/gutenberg-core/v10.4.0-rc.1/vendor/react-dom.min.de439aae.js?m=1599596311h:14:21223)
    at Th (https://s0.wp.com/wp-content/plugins/gutenberg-core/v10.4.0-rc.1/vendor/react-dom.min.de439aae.js?m=1599596311h:11:728)
    at tj (https://s0.wp.com/wp-content/plugins/gutenberg-core/v10.4.0-rc.1/vendor/react-dom.min.de439aae.js?m=1599596311h:11:657)
    at Te (https://s0.wp.com/wp-content/plugins/gutenberg-core/v10.4.0-rc.1/vendor/react-dom.min.de439aae.js?m=1599596311h:10:7238)
    at https://s0.wp.com/wp-content/plugins/gutenberg-core/v10.4.0-rc.1/vendor/react-dom.min.de439aae.js?m=1599596311h:7:1114
    at unstable_runWithPriority (https://s0.wp.com/wp-content/plugins/gutenberg-core/v10.4.0-rc.1/vendor/react.min.e713ea3b.js?m=1599596311h:3:3396)
    at Da (https://s0.wp.com/wp-content/plugins/gutenberg-core/v10.4.0-rc.1/vendor/react-dom.min.de439aae.js?m=1599596311h:7:824)
    at Pg (https://s0.wp.com/wp-content/plugins/gutenberg-core/v10.4.0-rc.1/vendor/react-dom.min.de439aae.js?m=1599596311h:7:1060)

Gutenberg: v10.4.0-rc.1

Slack ref p1617868087136500-slack-CBTN58FTJ

[mirka]

Some P2-specific issues I'm noticing:

1. ✅ Fixed in D60017-code — These two wp-admin stylesheets are now being loaded in the front-end.

   <link rel='stylesheet' id='common-css'  href='https://foobar.wordpress.com/wp-admin/css/common.min.css?m=1617872750h&#038;ver=5.7.1-RC1-50691' type='text/css' media='all' />
   <link rel='stylesheet' id='forms-css'  href='https://foobar.wordpress.com/wp-admin/css/forms.min.css?m=1617199278h&#038;ver=5.7.1-RC1-50691' type='text/css' media='all' />

   These include a lot of type-selector styles like these, which has a broad effect on the existing cascade.

   .wp-die-message, p {
     font-size: 13px;
     line-height: 1.5;
     margin: 1em 0;
   }

   I'm guessing these stylesheets are coming from somewhere in Gutenberg's style dependency tree, but not immediately sure whether it's something to be addressed upstream or in P2.

2. ✅ Fixed in 2493-gh-automattic/p2 — Something about focus management changed, and the main P2 editor can now collapse right after opening. This is likely something to be addressed in P2 or P2 Editor.

   Steps to repro:

   1. Click the main editor placeholder to expand.

   2. Click the Reply button on the first post.

   3. Click the main editor placeholder again.

      

[davipontesblog]

Getting the same error as @Robertght mentioned on all edge sites I have.

#51813

[synora]

I'm able to reproduce a similar error message with the Edge sticker off and on

Link to image: https://d.pr/i/9pUC5J

[fullofcaffeine]

This is done. Next one: #51997.