Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Unification: Cannot access WP Admin -> themes.php #48147

Closed
serabi opened this issue Dec 8, 2020 · 10 comments
Closed

Nav Unification: Cannot access WP Admin -> themes.php #48147

serabi opened this issue Dec 8, 2020 · 10 comments
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@serabi
Copy link

serabi commented Dec 8, 2020

Steps to reproduce

  1. Go to WP Admin.
  2. Click on Themes. You are redirected to Calypso.

I am reporting this as a bug because:

  • HEs use the WP Admin -> Themes functionality to reactivate retired themes for users.
  • This functionality is also used to activate retired themes on test sites.
@serabi serabi changed the title Nav Unification: Cannot access WP Admins theme window Nav Unification: Cannot access WP Admin themes.php Dec 8, 2020
@serabi serabi changed the title Nav Unification: Cannot access WP Admin themes.php Nav Unification: Cannot access WP Admin -> themes.php Dec 8, 2020
@cathymcbride cathymcbride added the [Type] Bug When a feature is broken and / or not performing as intended label Dec 16, 2020
@cpapazoglou
Copy link
Contributor

Even if the URL doesn't appear, it is and will be reachable through [DOMAIN]/wp-admin/themes.php. Is there a need for the customers to easily access /wp-admin/themes.php?

@obenland
Copy link
Member

obenland commented Jan 5, 2021

Would it help if we added a Themes link under "Dash" in the superadminbar?

image

@JoshuaGoode
Copy link

JoshuaGoode commented Jan 7, 2021

For Atomic, many third-party themes include options, support buttons, and more when inspecting the theme details under Appearance > Themes.

Additionally, since we no longer force require auto-updates for themes, it's where users can toggle on/off updates for a specific theme.

I suppose this would be partially taken care of via the opt-out discussed on #47043

Screenshot from an Atomic site's WP-Admin > Appearance > Themes > Theme Details

nav_unification_themes

@obenland
Copy link
Member

Theme options should still be accessible through the admin menu.

However we are pretty much removing the ability to install themes from the theme directory. Unless there's an alternate way that I'm not aware of?

/cc @davemart-in

@davemart-in
Copy link
Contributor

However we are pretty much removing the ability to install themes from the theme directory.

Can you walk me through his statement @obenland? I'm not sure I follow.

@obenland
Copy link
Member

obenland commented Jan 15, 2021

Screen Shot 2021-01-15 at 9 21 44 AM

In themes.php there's an "Add new" button that leads users to theme-install.php, where they can browse the theme directory and install themes.

wordpress.com/themes offers an upload functionality where users can install a theme zip file, but besides that are limited to the themes that are available on dotcom.

image

Long term we should probably add a way to browse the directory to Calypso's theme screen.

@davemart-in
Copy link
Contributor

Phoning a friend: Hi @ianstewart!

Thoughts on whether we default to the Calypso themes selection screen or the wp-admin one?

@obenland
Copy link
Member

#43337 would help with this.

@cpapazoglou cpapazoglou added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Jan 20, 2021
@ianstewart
Copy link
Contributor

@davemart-in I think we should default to the Calypso one as there's a lot of custom code surrounding it all.

@obenland
Copy link
Member

Thanks @ianstewart!

#47043 will add a way to access the wp-admin version in the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

7 participants