-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav Unification: Show a modal to customers the first time they log in #47049
Comments
@davemart-in could you please elaborate more on this? Do we have any designs, user journey? |
I'll cc @sfougnier on this one. |
I have been exploring using a stepped approach that allows us to showcase the updated features. The intention of this is to introduce the unified nav and tell a brief story of how it works in an attempt to cut down on any confusion. A few things:
Desktop Mobile |
Thanks @sfougnier for working on this! This stepped approach seems very good and makes sense!
I understand that the copy is not final, but is the
I don't see a blocker here, go for it! We just need to make sure that we create images / gifs for the variation that we will launch (currently we have developed only i1). |
Agreed, I definitely don't think we would want to include that jargon here. I imagine that can be cut, but I am not the best wordsmith and wanted to express intent here.
Awesome! I can work on creating those. |
For pairing this modal with the sidebar design that's currently being tested, let's use static designs: For any design improvements, adding some animated GIFs would be preferred: Design i1 JPGs Design i2 GIFs, JPGs + mp4 walkthrough videos Design files |
@davemart-in Priority-wise, should this still go into next iteration or should we focus on alpha feedback first? |
@sfougnier I am afraid you have created visuals with the new designs (i2) that are not developed. Should we create the visuals with i1? Or is it something I am missing? |
@davemart-in , sorry for the double ping ❤️ ! In which environments / cases should this modal be shown:
Also, are we showing it only once? |
@obenland Up to you. We'll need both before launch.
@cpapazoglou I'd say we could keep it to
Yes, users should only ever see this modal once. |
@cpapazoglou I added i1 visuals to my comment above. Let's keep anything i1 static for now and reserve the fancy GIFs for any design improvements. |
Scope and designs look to have been confirmed. This now requires investigation and quick research into how much effort is required so we have a handle on scope. |
Note: there's a WP.com What’s New Product Announcements feature (pbBQWj-AH-p2) that will do something similar in Calypso. They are using the core Guide component and it was suggested we consider this as well. |
Couple of questions:
|
That's a good question. Current plans, include enabling nav-unification for specific segments ( eg all users with User IDs ending in |
Thanks @cpapazoglou, I guess it will be based on the following criteria then:
On this last point. How do we want to track this state? The obvious answer would be localStorage however we know that if the user:
Then they will be shown the modal repeatedly which could become annoying/frustrating over time. For the Block Editor NUX modal this value is sent to a specific endpoint when dismissed. For comparison the Whats New modal isn't tracked at all, since it's accessible via the menu in the editor. Any ideas/preference around this aspect of the functionality? |
Hmm, now that I read my comment, my answer "yes" doesn't make sense. What I meant is, show the modal regardless of whether the user is new or existing. Just use
Not sure how this pbBQWj-AH-p2 will work, I suppose it should already have a tracking mechanism. FWIW though,
|
Sorry, I think I miscommunicated what I meant by tracking the state. The tracking you mention above is tracking events, whereas I meant how we want to keep track of the state of the modal so that we know it has been shown (e.g. persistent storage). I'll move towards a localStorage solution for now and we can update that if required. |
Nope, you did pretty well! I have probably guided you to the wrong line. Here you are wp-calypso/client/components/banner/index.jsx Lines 49 to 50 in ed3e915
with You can better understand how it works here wp-calypso/client/blocks/dismissible-card/index.jsx Lines 82 to 88 in 2b8a9b4
|
By the look of things the (Ignore the placeholder image) The way around this would be to use a It seems like there are two obvious options here:
cc: @sfougnier @getdave |
Thanks for checking in @tjcafferkey and for the nice research into this. Using the deprecated component would seem like it could cause maintenance issues down the line. As you say it looks like the The Issue appears to be that by default there is no built in mechanism for a "side-by-side" layout. How about we spin up Storybook locally and test to see if it's possible to provide markup + style overides to achieve a side-by-side layout using the Failing that, we should check whether @sfougnier is ok to adjust the design for the sake of expediency. If (as I suspect) it turns out that the side-by-side layout is a critical piece of the design, then we should get some context from the team that implemented the welcome modal as to why they decided it was ok to use the I'd like to avoid Ajax getting sidetracked with developing an entirely new component if possible. |
What's the reason we can't follow the same side-by-side layout that's in the What's new modal? |
@sfougnier sorry for not updating this issue yesterday. The good news is we are able to make it look like the What's New modal by overriding the However, we may need to deviate from the mobile designs (which look different to the What's New modal) because the markup doesn't allow for certain aspects of it, mainly around the pagination and its position. This PR should be ready for review today so it would be great if you could also cast your eye over it if you have time 😄 |
I think there are a couple of things to follow up:
|
@mmtr yes you're right. I'll be creating separate issues for these to follow up. |
We would need to iterate on the "new users" condition the day we actually launch to customers. |
I don't think this is necessary. The text in the screenshot is UI based, not informational. User's don't need to be able to read the text within the image to understand what is going on. |
Right, the rollout will be gradual, so we have to handle that. The modal should show up if the nav unification has been enabled for the current logged user after they signed up.
EDIT: I guess this can be simplified to:
And then update |
Looks like the modal that accidentally debuted earlier was using the wrong image asset. We should be using these since there's no current plan to implement the visual changes: |
What
If a user is logging in for the first time since the nav unification project is enabled, show them a modal explaining the recent changes.
Why
We need to help customers orient themselves to the change by explaining what has changed, the reasons behind it and how it will benefit them.
Acceptance criteria
Resources
For any design improvements, adding some animated GIFs would be preferred see #47049 (comment)
Design i1 JPGs:
Design i2 GIFs, JPGs + mp4 walkthrough videos:
Design files:
Related to #47047
The text was updated successfully, but these errors were encountered: