-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamburger button overlapping block inserter button on post editor on wp-admin. #40426
Comments
@jeherve was there some prior work / issue about this? |
It was previously fixed in Automattic/jetpack#12337 for the Masterbar in wp-admin. I'm not sure I understand what this issue is about though. Where does this happen? WordPress.com Simple, Atomic, Jetpack, wp-admin, Calypso? |
Interestingly my default experience is different (though not better) in Atomic, because of Calypsoify: If I disable Calypsoify I get what you're seeing. This would seem like a regression from Automattic/jetpack#12337 in Jetpack. I reopened Automattic/jetpack#12320 to track this. This issue may need to remain open for WordPress.com simple though. The masterbar there is different from the one in Jetpack. |
Brought this up in some masterbar-related discussions: pbAPfg-3G-p2#comment-988 |
TLDR Version: The fix is in this phab patch here: D44873-code Keeping things simpleI updated the description of this issue to limit the scope of the fix that should be done here. Previously the issue included:
Also, it is also interesting to note that:
Quick fix for the hamburger button overlapI've created a quick fix to reposition the hamburger button on the masterbar. The fix is in this phab patch here: D44873-code. I'm not sure if that's the right place to modify the CSS file. I can't quite tell if the CSS file is actually a built version that was sync'ed over from jetpack's repository? Even though I can't find the relevant files in jetpack's repository. |
Fixed in D44873-code |
See fix at: #40426 (comment)
Steps to reproduce
wp-admin/post-editor.php
.What happens
The hamburger button appears on top of the block inserter button. It's no longer possible to click on the block inserter menu.
Screenshot / Video
The text was updated successfully, but these errors were encountered: