-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Add spellcheck / proofreading feature #306
Comments
Also requested here: |
I've spent some time reviewing the technical requirements for integrating After the Deadline (AtD). There are several hurdles to being able to support it in Calypso, which I'll summarize below: First and foremost, the existing client-side solutions (official TinyMCE plugin) assume that an endpoint will be made available in proxying requests to the AtD service. For WordPress(.com), this is implemented as an
Further, we must consider support for ignored strings. In WordPress, this is saved as a user attribute. It may be in our interest to continue using this attribute so that ignored strings are preserved between wp-admin and Calypso editor sessions, or consider storing these settings in a local preference store. Options for moving forward:
Next, required dependencies will need to be ported to work in the Calypso environment. Neither the AtD TinyMCE plugin nor the core JavaScript library are designed to work in a CommonJS environment, nor are they made available on npm. If we follow preexisting patterns, we'd likely want to copy/fork these files to Calypso, rewriting specific portions to adhere to our coding standards, remove references to window globals, and export themselves as CommonJS consumable modules. Lastly, there is likely some minimal restyling effort required to align the appearance of the AtD suggestions popover with Calypso style standards. |
CORS support has been added to the AfterTheDeadline service, which should give us a path forward for implementing proofreading support in the Calypso editor without need for a proxy endpoint. I expect that major revisions will be required for the TinyMCE AtD plugin, particularly around communicating directly with the AtD service (instead of through a proxy endpoint) and in retrieving/persisting user preferences for ignored suggestions. |
Implement the proofreading/spellcheck feature in the Calypso editor.
Here's what it looks like in WP Admin:
The text was updated successfully, but these errors were encountered: