Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: misaligned dismiss button in validation #214

Closed
fabianapsimoes opened this issue Nov 19, 2015 · 8 comments
Closed

Sidebar: misaligned dismiss button in validation #214

fabianapsimoes opened this issue Nov 19, 2015 · 8 comments
Assignees
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug

Comments

@fabianapsimoes
Copy link
Contributor

After the recent changes in the sidebar, the dismiss button in validation messages became misaligned:

screenshot-wpcalypso wordpress com 2015-11-19 18-33-14

This affects at least /purchases/:site/:purchaseId/payment/edit/:cardId and /checkout, where this kind of validation is still used.

Reproduced using Firefox 40.0.3 for Linux.

cc @shaunandrews

@fabianapsimoes
Copy link
Contributor Author

The account verification notice also looks broken in /me/next, and the content there isn't aligned to the center of the page:

screenshot-wpcalypso wordpress com 2015-11-19 19-10-39

This notice looks fine in other pages though:

screenshot-wpcalypso wordpress com 2015-11-19 19-17-03

@johnHackworth
Copy link
Contributor

Also, when the notice is a sticky one and you scroll, it gets shortened and the effect is odd:

image

@shaunandrews
Copy link
Contributor

The alignment of the next screen is being tracked over in 12544-gh-calypso-pre-oss

I'm looking at how to fix the notices. @rickybanister, you mentioned that we'll be updating notices in the next few weeks?

@shaunandrews shaunandrews self-assigned this Nov 19, 2015
@jeffgolenski
Copy link
Member

Also found a misaligned dismiss icon, during the wpcom sign-up flow.

cc08c492-8ed6-11e5-882a-d29a40576f69-2

@stephanethomas
Copy link
Contributor

Note the account verification notice breaks the DevDocs page: #259.

@fabianapsimoes fabianapsimoes added [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. and removed [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. Upgrades labels Nov 20, 2015
shaunandrews added a commit that referenced this issue Nov 20, 2015
@shaunandrews
Copy link
Contributor

I'm working on these over in #302

@koke
Copy link
Member

koke commented Nov 23, 2015

In case it provides new info, I got one of these when saving account settings

screen shot 2015-11-23 at 16 06 39

shaunandrews added a commit that referenced this issue Nov 26, 2015
This avoids the misaligned dismiss button mentioned in #214

Removing the unnecessary adjustments on <Notice> for the sidebar — this
is all handled by the notice’s parent element .wp-content. Also fixed
.is-pinned to work with the new margins and widths. For some reason, I
can’t use the $sidebar-width-min/max SCSS variables here.
@designsimply designsimply removed the [Feature] Notifications Site notifications. label Dec 30, 2015
@fabianapsimoes
Copy link
Contributor Author

Looks like the issues in this issue have been addressed. I'm closing, but feel free to reopen in case you see any other weirdness in Purchases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug
Projects
None yet
Development

No branches or pull requests

8 participants