-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar: misaligned dismiss button in validation #214
Comments
The alignment of the next screen is being tracked over in 12544-gh-calypso-pre-oss I'm looking at how to fix the notices. @rickybanister, you mentioned that we'll be updating notices in the next few weeks? |
Note the account verification notice breaks the |
misaligned dismiss button mentioned in #214
I'm working on these over in #302 |
This avoids the misaligned dismiss button mentioned in #214 Removing the unnecessary adjustments on <Notice> for the sidebar — this is all handled by the notice’s parent element .wp-content. Also fixed .is-pinned to work with the new margins and widths. For some reason, I can’t use the $sidebar-width-min/max SCSS variables here.
Looks like the issues in this issue have been addressed. I'm closing, but feel free to reopen in case you see any other weirdness in Purchases. |
After the recent changes in the sidebar, the dismiss button in validation messages became misaligned:
This affects at least
/purchases/:site/:purchaseId/payment/edit/:cardId
and/checkout
, where this kind of validation is still used.Reproduced using Firefox 40.0.3 for Linux.
cc @shaunandrews
The text was updated successfully, but these errors were encountered: