Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: Fill credit card form with data upon loading Edit Card Details page #193

Closed
mikeshelton1503 opened this issue Nov 19, 2015 · 7 comments · Fixed by #485
Closed
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug When a feature is broken and / or not performing as intended
Milestone

Comments

@mikeshelton1503
Copy link
Contributor

On a purchase where a CC used as the payment method when you click "Edit Payment Method" the form loads up empty instead of allowing you to edit the CC details. If you then try to reenter your CC details, you can successfully update, however it adds it as a new credit card.

Also when you click the "Update Card" button it should disable to indicate processing.

@mikeshelton1503 mikeshelton1503 added [Type] Bug When a feature is broken and / or not performing as intended Upgrades labels Nov 19, 2015
@mikeshelton1503 mikeshelton1503 added this to the Purchases: Manage milestone Nov 19, 2015
@stephanethomas stephanethomas self-assigned this Nov 19, 2015
@fabianapsimoes fabianapsimoes modified the milestones: Purchases: Manage, Purchases: v1 Nov 19, 2015
@stephanethomas
Copy link
Contributor

Note I've created #260 to be able to disable input fields while loading stored credit card data from the API. The Updated Card button should also be disabled during that stage.

@stephanethomas stephanethomas changed the title Purchases: Credit card details cleared out when editing payment method Purchases: Fill credit card form with data upon loading Edit Card Details page Nov 20, 2015
@fabianapsimoes fabianapsimoes added [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. and removed [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. Upgrades labels Nov 20, 2015
@scruffian scruffian added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Awaiting Fixes [Status] Needs Author Reply and removed [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Awaiting Fixes [Status] Needs Author Reply labels Nov 23, 2015
@stephanethomas
Copy link
Contributor

#485 takes care of the card holder name. We will handle the country and postal code in another pull request. We will remove the country and postal code returned with the payment data in the /me/purchases endpoint and update the /me/stored-cards endpoint to return it. That way this data is only located in the Stored Cards store.

@scruffian scruffian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 24, 2015
@stephanethomas
Copy link
Contributor

I'm reopening this issue since we should also populate the country and postal code.

@stephanethomas stephanethomas removed their assignment Dec 11, 2015
@fabianapsimoes
Copy link
Contributor

#485 takes care of the card holder name

The form is pre-filled when we click the Edit Payment Method button, but not when you click the Payment Method section.

screenshot-wordpress com 2016-02-24 16-10-29

@gziolo
Copy link
Member

gziolo commented Apr 28, 2016

As a part of #5074 fix I removed editSpecificCardDetails path. If we decide to implement this issue we should revert those changes. Otherwise we should completely remove logic related to filling credit card form with data upon loading.

@fabianapsimoes
Copy link
Contributor

Removing this from Amber: Backlog, as it'd probably be better handled by Team Gold.

@fabianapsimoes fabianapsimoes modified the milestones: Amber: Backlog, Gold: backlog Jun 2, 2016
@peterbutler peterbutler modified the milestones: Gold: backlog, Gold: Triage Jun 2, 2016
@gziolo
Copy link
Member

gziolo commented Nov 21, 2016

It loads first name at the moment upon loading Edit Card Details page which okey. Closing this one. We can open new issue if we plan to change this logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
6 participants