Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Body file dropzone collapses in HTML mode #18535

Closed
iandunn opened this issue Oct 4, 2017 · 0 comments
Closed

Editor: Body file dropzone collapses in HTML mode #18535

iandunn opened this issue Oct 4, 2017 · 0 comments
Assignees
@iandunn
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended

Comments

@iandunn
Copy link
Contributor

iandunn commented Oct 4, 2017 •
edited
Loading

#16819 introduced a bug where the dropzone for the editor body is collapsed in HTML-editing mode.

Steps to reproduce

  1. Open a new or existing post
  2. Switch to the HTML editor tab
  3. Drag an image onto the screen

What I expected

The file drop should take up the entire body of the editor.

What happened instead

The (blue) file drop appears, but is only ~10px tall.

Browser / OS version

Chrome 61

Screenshot / Video

screen shot 2017-10-04 at 9 31 30 am 2
@iandunn iandunn added [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended labels Oct 4, 2017
@iandunn iandunn self-assigned this Oct 4, 2017
@iandunn iandunn mentioned this issue Oct 5, 2017
Closed
iandunn added a commit that referenced this issue Oct 10, 2017
@iandunn
Editor: Style HTML-mode dropzone to cover entire editor body
5fd5250 
A bug was introduced in #16819 which collapsed the editor's dropzone when in HTML-editing mode. Before that PR, the dropzone was full-screen, but now it needs to be constrained to the editor body, in order to leave room for the featured-image dropzones.

Fixes #18535
iandunn added a commit that referenced this issue Oct 10, 2017
@iandunn
Editor: Move HTML-mode dropzone higher in DOM to cover editor body
307ab2b 
When in HTML-mode, the Editor has a dropzone for uploading files and inserting them into the post body. Because of #18535, that dropzone is currently only 10px tall, when it should take up the entire body of the editor.

The editor's HTML-mode media dropzone was introduced in #11680. At the time, there weren't any other dropzones on the screen -- the sidebar featured image zone was added a week later, in #11839 -- so the HTML-mode dropzone took up the entire screen.

Because it could take up the entire screen, its placement inside the editor-html-toolbar didn't pose any tangible problems.

When a third dropzone was added in #16819, the HTML-mode dropzone has its fullscreen prop disabled, so that the new dropzone would be accessible. The changes in this PR should have been done at that time, but it was overlooked. Because they weren't done, the media dropzone is currently only 10px tall, instead of covering the entire editor body. This makes it difficult for someone to drop a file in the correct location.

Because there are now multiple dropzones on the editor screen, the HTML-mode dropzone should only cover the editor body itself, not the entire screen. In order to achieve that, it needs to be moved above the editor-html-toolbar in the DOM, since the toolbar is restricted to be 40px tall.

Fixes #18535
@iandunn iandunn mentioned this issue Oct 10, 2017
Merged
iandunn added a commit that referenced this issue Oct 11, 2017
@iandunn
Editor: Style HTML-mode dropzone to cover entire editor body
9b11627 
A bug was introduced in #16819 which collapsed the editor's dropzone when in HTML-editing mode. Before that PR, the dropzone was full-screen, but now it needs to be constrained to the editor body, in order to leave room for the featured-image dropzones.

Fixes #18535
iandunn added a commit that referenced this issue Oct 11, 2017
@iandunn
Editor: Style HTML-mode dropzone to cover entire editor body
fbd297a 
A bug was introduced in #16819 which collapsed the editor's dropzone when in HTML-editing mode. Before that PR, the dropzone was full-screen, but now it needs to be constrained to the editor body, in order to leave room for the featured-image dropzones.

Fixes #18535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iandunn iandunn

Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iandunn