Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: unsubscribed state still active after renewal #161

Closed
fabianapsimoes opened this issue Nov 19, 2015 · 2 comments
Closed

Purchases: unsubscribed state still active after renewal #161

fabianapsimoes opened this issue Nov 19, 2015 · 2 comments
Assignees
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug

Comments

@fabianapsimoes
Copy link
Contributor

Reported by @TheSteveK.

The unsubscribed state noticed is still displayed after renewal, for a short moment. This shouldn't happen as renewals resubscribe unsubscribed products.

Steps to reproduce:

  • Go to /purchases and select an unsubscribed product.
  • You'll see the unsubscribed state notice, prompting users to renew.
  • Click Renew Now and complete checkout.
  • You'll be redirected back to Manage Purchase. Note that the unsubscribed state notice is still there, though it disappears in a few seconds once the information about the subscription is updated.

Before:
screenshot-wpcalypso wordpress com 2015-11-19 12-38-38

After:
screenshot-wpcalypso wordpress com 2015-11-19 12-38-44

Related to 11802-gh-calypso-pre-oss (cc @andreabadgley who also noted this back then).

@fabianapsimoes fabianapsimoes added this to the Purchases: View milestone Nov 19, 2015
@fabianapsimoes fabianapsimoes added [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. and removed [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. Upgrades labels Nov 20, 2015
@scruffian
Copy link
Member

This can probably be fixed together with #189.

@drewblaisdell
Copy link
Contributor

The current solution for #189 is to replace the currently saved purchase object with a new one returned by the cancel-private-registration endpoint, so this will probably need to be fixed in a separate PR.

Unless anyone has a better one, I think a realistic solution for v1 is just to display the entire ManagePurchase placeholder state until we've fetched the purchases again.

@drewblaisdell drewblaisdell added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 24, 2015
@drewblaisdell drewblaisdell added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 25, 2015
jsnajdr pushed a commit that referenced this issue Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug
Projects
None yet
Development

No branches or pull requests

4 participants