Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Header Cake: layout issues when Back is a longer string #143

Closed
hoverduck opened this issue Nov 18, 2015 · 5 comments · Fixed by #1514
Closed

Components: Header Cake: layout issues when Back is a longer string #143

hoverduck opened this issue Nov 18, 2015 · 5 comments · Fixed by #1514

Comments

@hoverduck
Copy link
Contributor

This is how the Back link in HeaderCake looks in Swedish, in smaller screens (320px wide, in the screenshot):

image

@hoverduck hoverduck added [Type] Bug [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Components labels Nov 18, 2015
@rralian rralian added this to the Core: Iteration 17 milestone Nov 30, 2015
@adambbecker adambbecker self-assigned this Dec 2, 2015
@adambbecker
Copy link
Contributor

Okay, so after investigating this a bit, it seems we have three choices for a potential solutions:

Options

1. Leave as is

screen shot 2015-12-03 at 2 49 09 pm

The reason I'm including this is because currently the header cake title as well as the "back" text will always stay fully visible and the title will remain centered. We could also align the title to be in the middle of the card:

screen shot 2015-12-03 at 2 50 29 pm

2. Ellipsis "back" text

screen shot 2015-12-03 at 2 52 51 pm

This keeps the title centered, but ellipsis's the back text if it starts to overflow 1/3 width of the card.

3. Ellipsis title

screen shot 2015-12-03 at 2 42 35 pm

This option makes sure all the "back" text remains visible and not wrapping, then ellipsis's the title within the available space. It keeps everything in one line.

It does, however, look a little odd depending on the strings that are used if nothing is needing an ellipsis:

screen shot 2015-12-03 at 3 27 31 pm

4. Align title right & ellipsis

screen shot 2015-12-03 at 3 20 06 pm

This option forgoes trying to center the title and just aligns it to the right. The "back" text remains visible inline and the title also ellipsis's if it expands beyond the remaining space.

screen shot 2015-12-03 at 3 20 55 pm


Recommendation

I would probably recommend option 4 as it retains the "back" text visibility regardless of language, while still be informative as to the title. It also looks pretty decent at large sizes even if the page title is a little too verbose.

screen shot 2015-12-03 at 3 21 35 pm


Curious to hear your thoughts around any of the options mentioned above.

/cc @mtias

@mtias
Copy link
Member

mtias commented Dec 5, 2015

@adambbecker nice breakdown. I think your last proposal makes sense. Originally there were plans to support other items at the right, but I don't think there's any section using that space? (Maybe some of the store pages with the cart, but not sure.)

@adambbecker
Copy link
Contributor

@mtias: Great!

I did look through a whole variety of places where this component is being used and they all do not attempt to utilize that space. In the HeaderCake component itself, it doesn't actually strictly allow for that place to be used as the right corner element doesn't have any children, but did check that it's usage wasn't attempting to override that fact.

Here are a few examples of the right aligned method in use:

screen shot 2015-12-10 at 1 18 44 pm

screen shot 2015-12-10 at 1 18 51 pm

screen shot 2015-12-10 at 1 21 28 pm

screen shot 2015-12-10 at 1 22 29 pm

adambbecker added a commit that referenced this issue Dec 11, 2015
Cleans up "header cake" component and closes #143
adambbecker added a commit that referenced this issue Dec 17, 2015
Cleans up "header cake" component and closes #143
adambbecker added a commit that referenced this issue Jan 4, 2016
Cleans up "header cake" component and closes #143
adambbecker added a commit that referenced this issue Jan 29, 2016
Cleans up "header cake" component and closes #143
@fabianapsimoes
Copy link
Contributor

@adambbecker looks like this is still an issue. See #3431.

@hoverduck
Copy link
Contributor Author

26May16 Bug Scrub

Closing, looks to be fixed. Here is the DE layout referenced in #3431 at 320px wide:

screen shot 2016-05-26 at 1 33 58 pm

@lancewillett lancewillett removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants