Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: Users and sites purchases not loaded correctly #1111

Closed
scruffian opened this issue Dec 1, 2015 · 3 comments
Closed

Purchases: Users and sites purchases not loaded correctly #1111

scruffian opened this issue Dec 1, 2015 · 3 comments
Assignees
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@scruffian
Copy link
Member

When loading a site's purchases before a user's purchases, the collections aren't properly merged meaning that both appear in the list:

screenshot 2015-12-01 15 25 40

We need to ensure that they are properly merged together to prevent this happening.

@scruffian scruffian added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Dec 1, 2015
@scruffian scruffian added this to the Purchases: v1 milestone Dec 1, 2015
@fabianapsimoes
Copy link
Contributor

@scruffian when would this happen? Do we have steps to reproduce?

@scruffian
Copy link
Member Author

This situation doesn't seem to happen any more; the bug has mutated. It now works like this:

If I have an account with purchases for more than one site, when I visit /purchases directly I see this:
screen shot 2016-03-21 at 09 38 23

However if I next navigate to /settings/general/:site, for one of the sites with purchases, (you have to navigate, not go there directly) and then return to /purchases, I see this:
screen shot 2016-03-21 at 09 38 00

Now if I visit /settings/general/:site, directly and then navigate to to /purchases I see this:
screen shot 2016-03-21 at 09 38 42

The issue is that on both /purchases and /settings/general/:site we fetch a list of purchases, but they aren't the same list, so we need to handle these cases better.

@scruffian scruffian changed the title Purchases: Users and sites purchases not merged Purchases: Users and sites purchases not loaded correctly Mar 21, 2016
@kriskarkoski
Copy link
Contributor

I recently encountered this on a user's site (multiple domain subs instead of one, no cancel option on the main domain card) and noticed that once auto renewal was disabled from SA the issue went away. Re-enabling auto renew did not allow the issue to happen again so disable auto renew once "fixed" whatever was causing them to be split and have the cancel option missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants