Calypsoify overrides link targets so they open outside of iframe

Automattic · Jun 15, 2020 · a21d6fa · a21d6fa
1 parent e165dab
commit a21d6fa
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/...l-site-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/create-page/index.tsx b/...l-site-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/create-page/index.tsx
@@ -33,7 +33,12 @@ export default function CreatePage( { postType }: Props ) {
 	);
 
 	return (
-		<Button isPrimary className="wpcom-block-editor-nav-sidebar-create-page" href={ url }>
+		<Button
+			target={ applyFilters( 'a8c.WpcomBlockEditorNavSidebar.linkTarget', undefined ) }
+			isPrimary
+			className="wpcom-block-editor-nav-sidebar-create-page"
+			href={ url }
+		>
 			{ label }
 		</Button>
 	);

diff --git a/...ite-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/view-all-posts/index.tsx b/...ite-editing-plugin/wpcom-block-editor-nav-sidebar/src/components/view-all-posts/index.tsx
@@ -37,7 +37,12 @@ export default function ViewAllPosts( { postType }: Props ) {
 	);
 
 	return (
-		<Button isSecondary className="wpcom-block-editor-nav-sidebar-view-all-posts" href={ url }>
+		<Button
+			target={ applyFilters( 'a8c.WpcomBlockEditorNavSidebar.linkTarget', undefined ) }
+			isSecondary
+			className="wpcom-block-editor-nav-sidebar-view-all-posts"
+			href={ url }
+		>
 			{ label }
 		</Button>
 	);

diff --git a/apps/wpcom-block-editor/src/calypso/features/iframe-bridge-server.js b/apps/wpcom-block-editor/src/calypso/features/iframe-bridge-server.js
@@ -818,6 +818,13 @@ function getCalypsoUrlInfo( calypsoPort ) {
 			return url;
 		}
 	);
+
+	// All links should open outside the iframe
+	addFilter(
+		'a8c.WpcomBlockEditorNavSidebar.linkTarget',
+		'wpcom-block-editor/getSiteSlug',
+		() => '_parent'
+	);
 }
 
 /**