-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch wc.data for Gutenberg 15.5+ and wc < 7.7.0 #1086
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 182 kB ℹ️ View Unchanged
|
chihsuan
force-pushed
the
fix/wc-data-patch
branch
from
April 21, 2023 05:10
2fbd6d4
to
3e2b2d6
Compare
Co-authored-by: Adrian Duffell <[email protected]>
rjchow
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tis a work of art 🚀
Tested great in 7.6, amazing work @chihsuan 🏅 🚀 |
chihsuan
changed the title
Patch wc.data for Gutenberg 15.5+ and wc <= 7.6.0
Patch wc.data for Gutenberg 15.5+ and wc < 7.7.0
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR is monkey-patching the
@woocommemrce/data
to fix the critical bugs (Automattic/wp-calypso#76000, Automattic/wp-calypso#76054) caused by incorrect behavior ofuseSelect
(p7H4VZ-4ei-p2) and WordPress/gutenberg#47243 changes.This includes the following WC Core PRs fixes (They will be released in WC 7.7):
More details:
p1681992263690669-slack-C025EHY377G
p1682035739861559-slack-C01SFMVEYAK
How to test the changes in this Pull Request:
wc-calypso-bridge/includes/class-wc-calypso-bridge-woocommerce-admin-features.php
Lines 93 to 95 in f7cef00
wc-calypso-bridge/includes/class-wc-calypso-bridge-woocommerce-admin-features.php
Lines 136 to 137 in f7cef00
4.Go to WooCommerce -> Settings -> Features
5. Enable the Navigation feature:
wp option set woocommerce_navigation_enabled yes
peError: object null is not iterable (cannot read property Symbol(Symbol.iterator))
in dev consoleOther information:
FOR PR REVIEWER ONLY: