Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch wc.data for Gutenberg 15.5+ and wc < 7.7.0 #1086

Merged
merged 7 commits into from
Apr 21, 2023
Merged

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented Apr 21, 2023

Changes proposed in this Pull Request:

This PR is monkey-patching the @woocommemrce/data to fix the critical bugs (Automattic/wp-calypso#76000, Automattic/wp-calypso#76054) caused by incorrect behavior of useSelect (p7H4VZ-4ei-p2) and WordPress/gutenberg#47243 changes.

This includes the following WC Core PRs fixes (They will be released in WC 7.7):

More details:
p1681992263690669-slack-C025EHY377G
p1682035739861559-slack-C01SFMVEYAK

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Remove Navigation disable code

4.Go to WooCommerce -> Settings -> Features
5. Enable the Navigation feature:

  • Undo changes from this PR to enable the new navigation option
  • Or run wp option set woocommerce_navigation_enabled yes
  1. Confirm there are errors peError: object null is not iterable (cannot read property Symbol(Symbol.iterator)) in dev console
  2. Apply this patch
  3. Confirm the no errors in the dev console
  4. You might still not see the navigation menu in /wp-admin/admin.php?page=wc-settings&tab=advanced I'm not really sure why, but I think it's something related to bridge/atomic code
  5. Go to wp-admin/admin.php?page=wc-admin
  6. Confirm navigation works

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@chihsuan chihsuan self-assigned this Apr 21, 2023
@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Size Change: 0 B

Total Size: 182 kB

ℹ️ View Unchanged
Filename Size
./build/948.js 917 B
./build/index.css 2.1 kB
./build/index.js 176 kB
./build/style-index.css 2.65 kB

compressed-size-action

@chihsuan chihsuan marked this pull request as ready for review April 21, 2023 03:38
@chihsuan chihsuan requested review from a team, moon0326 and rjchow April 21, 2023 03:39
@chihsuan chihsuan force-pushed the fix/wc-data-patch branch from 2fbd6d4 to 3e2b2d6 Compare April 21, 2023 05:10
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tis a work of art 🚀

@chihsuan chihsuan merged commit 3670a5b into master Apr 21, 2023
@adrianduffell
Copy link
Contributor

Tested great in 7.6, amazing work @chihsuan 🏅 🚀

@chihsuan chihsuan mentioned this pull request Apr 21, 2023
1 task
@chihsuan chihsuan changed the title Patch wc.data for Gutenberg 15.5+ and wc <= 7.6.0 Patch wc.data for Gutenberg 15.5+ and wc < 7.7.0 Apr 21, 2023
@chihsuan chihsuan deleted the fix/wc-data-patch branch August 26, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants